+constructor Last

Author: amanomer

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala

@@ -304,12 +304,12 @@ object FunctionRegistry {
     expression[ApproximatePercentile]("approx_percentile"),
     expressionWithAlias[StddevSamp]("std"),
     expressionWithAlias[StddevSamp]("stddev"),
-    expression[StddevPop]("stddev_pop"),
     expressionWithAlias[StddevSamp]("stddev_samp"),
+    expression[StddevPop]("stddev_pop"),
     expression[Sum]("sum"),
     expressionWithAlias[VarianceSamp]("variance"),
-    expression[VariancePop]("var_pop"),
     expressionWithAlias[VarianceSamp]("var_samp"),
+    expression[VariancePop]("var_pop"),
     expression[CollectList]("collect_list"),
     expression[CollectSet]("collect_set"),
     expression[CountMinSketchAgg]("count_min_sketch"),

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/First.scala

@@ -47,10 +47,9 @@ import org.apache.spark.sql.types._
 case class First(funcName: String, child: Expression, ignoreNullsExpr: Expression)
   extends DeclarativeAggregate with ExpectsInputTypes {
 
-  def this(child: Expression) = this("first", child, Literal.create(false, BooleanType))
+  def this(child: Expression) = this(child, Literal.create(false, BooleanType))
 
-  def this(child: Expression, ignoreNullsExpr: Expression) =
-    this("first", child, ignoreNullsExpr)
+  def this(child: Expression, ignoreNullsExpr: Expression) = this("first", child, ignoreNullsExpr)
 
   override def children: Seq[Expression] = child :: ignoreNullsExpr :: Nil
 

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala

@@ -47,7 +47,9 @@ import org.apache.spark.sql.types._
 case class Last(funcName: String, child: Expression, ignoreNullsExpr: Expression)
   extends DeclarativeAggregate with ExpectsInputTypes {
 
-  def this(child: Expression) = this("last", child, Literal.create(false, BooleanType))
+  def this(child: Expression) = this(child, Literal.create(false, BooleanType))
+
+  def this(child: Expression, ignoreNullsExpr: Expression) = this("last", child, ignoreNullsExpr)
 
   override def children: Seq[Expression] = child :: ignoreNullsExpr :: Nil
 

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala

@@ -1510,15 +1510,15 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
    */
   override def visitFirst(ctx: FirstContext): Expression = withOrigin(ctx) {
     val ignoreNullsExpr = ctx.IGNORE != null
-    First("first", expression(ctx.expression), Literal(ignoreNullsExpr)).toAggregateExpression()
+    new First(expression(ctx.expression), Literal(ignoreNullsExpr)).toAggregateExpression()
   }
 
   /**
    * Create a [[Last]] expression.
    */
   override def visitLast(ctx: LastContext): Expression = withOrigin(ctx) {
     val ignoreNullsExpr = ctx.IGNORE != null
-    Last("last", expression(ctx.expression), Literal(ignoreNullsExpr)).toAggregateExpression()
+    new Last(expression(ctx.expression), Literal(ignoreNullsExpr)).toAggregateExpression()
   }
 
   /**

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/LastTestSuite.scala

@@ -23,9 +23,9 @@ import org.apache.spark.sql.types.IntegerType
 
 class LastTestSuite extends SparkFunSuite {
   val input = AttributeReference("input", IntegerType, nullable = true)()
-  val evaluator = DeclarativeAggregateEvaluator(Last("last", input, Literal(false)), Seq(input))
+  val evaluator = DeclarativeAggregateEvaluator(new Last(input, Literal(false)), Seq(input))
   val evaluatorIgnoreNulls = DeclarativeAggregateEvaluator(
-    Last("last", input, Literal(true)), Seq(input))
+    new Last(input, Literal(true)), Seq(input))
 
   test("empty buffer") {
     assert(evaluator.initialize() === InternalRow(null, false))

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala

@@ -789,8 +789,8 @@ class ExpressionParserSuite extends AnalysisTest {
   test("SPARK-19526 Support ignore nulls keywords for first and last") {
     assertEqual("first(a ignore nulls)", new First('a, Literal(true)).toAggregateExpression())
     assertEqual("first(a)", new First('a, Literal(false)).toAggregateExpression())
-    assertEqual("last(a ignore nulls)", Last("last", 'a, Literal(true)).toAggregateExpression())
-    assertEqual("last(a)", Last("last", 'a, Literal(false)).toAggregateExpression())
+    assertEqual("last(a ignore nulls)", new Last('a, Literal(true)).toAggregateExpression())
+    assertEqual("last(a)", new Last('a, Literal(false)).toAggregateExpression())
   }
 
   test("Support respect nulls keywords for first_value and last_value") {
@@ -801,10 +801,11 @@ class ExpressionParserSuite extends AnalysisTest {
     assertEqual("first_value(a)",
       new First('a, Literal(false)).toAggregateExpression())
     assertEqual("last_value(a ignore nulls)",
-      Last("last", 'a, Literal(true)).toAggregateExpression())
+      new Last('a, Literal(true)).toAggregateExpression())
     assertEqual("last_value(a respect nulls)",
-      Last("last", 'a, Literal(false)).toAggregateExpression())
-    assertEqual("last_value(a)", Last("last", 'a, Literal(false)).toAggregateExpression())
+      new Last('a, Literal(false)).toAggregateExpression())
+    assertEqual("last_value(a)",
+      new Last('a, Literal(false)).toAggregateExpression())
   }
 
   test("timestamp literals") {

sql/core/src/main/scala/org/apache/spark/sql/functions.scala

@@ -556,7 +556,7 @@ object functions {
    * @since 2.0.0
    */
   def last(e: Column, ignoreNulls: Boolean): Column = withAggregateFunction {
-    new Last("last", e.expr, Literal(ignoreNulls))
+    new Last(e.expr, Literal(ignoreNulls))
   }
 
   /**