Use tableExists in check for new table name

edgarRd · edgarRd · commit 71d9ad1b497f · 2019-08-13T11:07:17.000-07:00
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
@@ -154,10 +154,8 @@ class V2SessionCatalog(sessionState: SessionState) extends TableCatalog {
   }
 
   override def renameTable(oldIdent: Identifier, newIdent: Identifier): Unit = {
-    try {
-      if (Option(loadTable(newIdent)).isDefined) throw new TableAlreadyExistsException(newIdent)
-    } catch {
-      case _: NoSuchTableException =>
+    if (tableExists(newIdent)) {
+      throw new TableAlreadyExistsException(newIdent)
     }
 
     // Load table to make sure the table exists

Original file line number	Diff line number	Diff line change
`@@ -154,10 +154,8 @@ class V2SessionCatalog(sessionState: SessionState) extends TableCatalog {`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`override def renameTable(oldIdent: Identifier, newIdent: Identifier): Unit = {`
`157`		`- try {`
`158`		`- if (Option(loadTable(newIdent)).isDefined) throw new TableAlreadyExistsException(newIdent)`
`159`		`- } catch {`
`160`		`- case _: NoSuchTableException =>`
	`157`	`+ if (tableExists(newIdent)) {`
	`158`	`+ throw new TableAlreadyExistsException(newIdent)`
`161`	`159`	`}`
`162`	`160`
`163`	`161`	`// Load table to make sure the table exists`