fix catalyst test

Author: Davies Liu

sql/catalyst/src/main/java/org/apache/spark/sql/BaseMutableRow.java

@@ -19,14 +19,10 @@
 
 import org.apache.spark.sql.catalyst.InternalRow;
 import org.apache.spark.sql.catalyst.expressions.MutableRow;
+import org.apache.spark.unsafe.types.UTF8String;
 
 public abstract class BaseMutableRow extends InternalRow implements MutableRow {
 
-  @Override
-  public void update(int ordinal, Object value) {
-    throw new UnsupportedOperationException();
-  }
-
   @Override
   public void setInt(int ordinal, int value) {
     throw new UnsupportedOperationException();
@@ -64,6 +60,6 @@ public void setFloat(int ordinal, float value) {
 
   @Override
   public void setString(int ordinal, String value) {
-    throw new UnsupportedOperationException();
+    update(ordinal, UTF8String.fromString(value));
   }
 }

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala

@@ -27,6 +27,15 @@ import org.apache.spark.unsafe.types.UTF8String
  */
 abstract class InternalRow extends Row {
 
+  // default implementation for codegen (for a Row which does not have those types)
+  override def getBoolean(i: Int): Boolean = throw new UnsupportedOperationException
+  override def getByte(i: Int): Byte = throw new UnsupportedOperationException
+  override def getShort(i: Int): Short = throw new UnsupportedOperationException
+  override def getInt(i: Int): Int = throw new UnsupportedOperationException
+  override def getLong(i: Int): Long = throw new UnsupportedOperationException
+  override def getFloat(i: Int): Float = throw new UnsupportedOperationException
+  override def getDouble(i: Int): Double = throw new UnsupportedOperationException
+
   // This is only use for test
   override def getString(i: Int): String = getAs[UTF8String](i).toString
 

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala

@@ -173,7 +173,7 @@ object GenerateProjection extends CodeGenerator[Seq[Expression], Projection] {
         $initColumns
       }
 
-      public int size() { return ${expressions.length};}
+      public int length() { return ${expressions.length};}
       protected boolean[] nullBits = new boolean[${expressions.length}];
       public void setNullAt(int i) { nullBits[i] = true; }
       public boolean isNullAt(int i) { return nullBits[i]; }

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/CatalystTypeConvertersSuite.scala

@@ -40,7 +40,6 @@ class CatalystTypeConvertersSuite extends SparkFunSuite {
     val convertToScala = CatalystTypeConverters.createToScalaConverter(schema)
 
     val scalaRow = Row.fromSeq(Seq.fill(simpleTypes.length)(null))
-    println(s"${scalaRow.getClass} ${convertToScala(convertToCatalyst(scalaRow)).getClass} ")
     assert(convertToScala(convertToCatalyst(scalaRow)) === scalaRow)
   }