addressed comments and fixed test

Author: brkyvz

sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala

@@ -82,9 +82,9 @@ private[sql] object StatFunctions {
   /** Generate a table of frequencies for the elements of two columns. */
   private[sql] def crossTabulate(df: DataFrame, col1: String, col2: String): DataFrame = {
     val tableName = s"${col1}_$col2"
-    val distinctCol2 = df.select(col2).distinct.orderBy(col2).collect()
+    val distinctCol2 = df.select(col2).distinct.collect().sortBy(_.get(0).toString)
     val columnSize = distinctCol2.size
-    require(columnSize < 1e5, s"The number of distinct values for $col2, can't " +
+    require(columnSize < 1e4, s"The number of distinct values for $col2, can't " +
       s"exceed 1e5. Currently $columnSize")
     var i = 0
     val col2Map = distinctCol2.map { r =>

sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala

@@ -33,10 +33,10 @@ class DataFrameStatSuite extends FunSuite  {
     val crosstab = df.stat.crosstab("a", "b")
     val columnNames = crosstab.schema.fieldNames
     assert(columnNames(0) === "a_b")
-    assert(columnNames(1) === "1")
-    assert(columnNames(2) === "2")
+    assert(columnNames(1) === "0")
+    assert(columnNames(2) === "1")
     val rows: Array[Row] = crosstab.collect()
-    var count: Integer = 1
+    var count: Integer = 0
     rows.foreach { row =>
       assert(row.get(0).toString === count.toString)
       assert(row.getLong(1) === 1L)