Skip to content

Commit 63036ae

Browse files
committed
Update known_translations for contributor names and also fix a small issue in translate-contributors.py
## What changes were proposed in this pull request? This PR updates dev/create-release/known_translations to add more contributor name mapping. It also fixes a small issue in translate-contributors.py ## How was this patch tested? manually tested Author: Yin Huai <[email protected]> Closes #16423 from yhuai/contributors.
1 parent dba81e1 commit 63036ae

File tree

2 files changed

+40
-1
lines changed

2 files changed

+40
-1
lines changed

dev/create-release/known_translations

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,3 +165,40 @@ stanzhai - Stan Zhai
165165
tien-dungle - Tien-Dung Le
166166
xuchenCN - Xu Chen
167167
zhangjiajin - Zhang JiaJin
168+
ClassNotFoundExp - Fu Xing
169+
KevinGrealish - Kevin Grealish
170+
MasterDDT - Mitesh Patel
171+
VinceShieh - Vincent Xie
172+
WeichenXu123 - Weichen Xu
173+
Yunni - Yun Ni
174+
actuaryzhang - Wayne Zhang
175+
alicegugu - Gu Huiqin Alice
176+
anabranch - Bill Chambers
177+
ashangit - Nicolas Fraison
178+
avulanov - Alexander Ulanov
179+
biglobster - Liang Ke
180+
cenyuhai - Cen Yu Hai
181+
codlife - Jianfei Wang
182+
david-weiluo-ren - Weiluo (David) Ren
183+
dding3 - Ding Ding
184+
fidato13 - Tarun Kumar
185+
frreiss - Fred Reiss
186+
gatorsmile - Xiao Li
187+
hayashidac - Chie Hayashida
188+
invkrh - Hao Ren
189+
jagadeesanas2 - Jagadeesan A S
190+
jiangxb1987 - Jiang Xingbo
191+
jisookim0513 - Jisoo Kim
192+
junyangq - Junyang Qian
193+
krishnakalyan3 - Krishna Kalyan
194+
linbojin - Linbo Jin
195+
mpjlu - Peng Meng
196+
neggert - Nic Eggert
197+
petermaxlee - Peter Lee
198+
phalodi - Sandeep Purohit
199+
pkch - pkch
200+
priyankagargnitk - Priyanka Garg
201+
sharkdtu - Sharkd Tu
202+
shenh062326 - Shen Hong
203+
aokolnychyi - Anton Okolnychyi
204+
linbojin - Linbo Jin

dev/create-release/translate-contributors.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,9 @@ def generate_candidates(author, issues):
147147
lines = contributors_file.readlines()
148148
contributions = []
149149
for i, line in enumerate(lines):
150-
temp_author = line.strip(" * ").split(" -- ")[0]
150+
# It is possible that a line in the contributor file only has the github name, e.g. yhuai.
151+
# So, we need a strip() to remove the newline.
152+
temp_author = line.strip(" * ").split(" -- ")[0].strip()
151153
print "Processing author %s (%d/%d)" % (temp_author, i + 1, len(lines))
152154
if not temp_author:
153155
error_msg = " ERROR: Expected the following format \" * <author> -- <contributions>\"\n"

0 commit comments

Comments
 (0)