Skip to content

Commit 5ef6907

Browse files
AngersZhuuuuHyukjinKwon
authored andcommitted
[SPARK-33084][CORE][SQL] Rename Unit test file and use fake ivy link
### What changes were proposed in this pull request? According to #29966 (comment) Use wrong name about suite file, this pr to fix this problem. And change to use some fake ivy link for this test ### Why are the changes needed? Follow file name rule ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No Closes #31118 from AngersZhuuuu/SPARK-33084-FOLLOW-UP. Authored-by: angerszhu <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
1 parent ff49317 commit 5ef6907

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

core/src/test/scala/org/apache/spark/SparkContextSuite.scala

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1067,17 +1067,17 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
10671067
dependencyJars.foreach(jar => assert(sc.listJars().exists(_.contains(jar))))
10681068

10691069
assert(logAppender.loggingEvents.count(_.getRenderedMessage.contains(
1070-
"Added dependency jars of Ivy URI" +
1071-
" ivy://org.apache.hive:hive-storage-api:2.7.0?transitive=true")) == 1)
1070+
"Added dependency jars of Ivy URI " +
1071+
"ivy://org.apache.hive:hive-storage-api:2.7.0?transitive=true")) == 1)
10721072

10731073
// test dependency jars exist
10741074
sc.addJar("ivy://org.apache.hive:hive-storage-api:2.7.0?transitive=true")
10751075
assert(logAppender.loggingEvents.count(_.getRenderedMessage.contains(
1076-
"The dependency jars of Ivy URI" +
1077-
" ivy://org.apache.hive:hive-storage-api:2.7.0?transitive=true")) == 1)
1076+
"The dependency jars of Ivy URI " +
1077+
"ivy://org.apache.hive:hive-storage-api:2.7.0?transitive=true")) == 1)
10781078
val existMsg = logAppender.loggingEvents.filter(_.getRenderedMessage.contains(
1079-
"The dependency jars of Ivy URI" +
1080-
" ivy://org.apache.hive:hive-storage-api:2.7.0?transitive=true"))
1079+
"The dependency jars of Ivy URI " +
1080+
"ivy://org.apache.hive:hive-storage-api:2.7.0?transitive=true"))
10811081
.head.getRenderedMessage
10821082
dependencyJars.foreach(jar => assert(existMsg.contains(jar)))
10831083
}
@@ -1109,8 +1109,8 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
11091109
"invalidParam1=foo&invalidParam2=boo")
11101110
assert(sc.listJars().exists(_.contains("org.apache.hive_hive-storage-api-2.7.0.jar")))
11111111
assert(logAppender.loggingEvents.exists(_.getRenderedMessage.contains(
1112-
"Invalid parameters `invalidParam1,invalidParam2` found in Ivy URI query" +
1113-
" `invalidParam1=foo&invalidParam2=boo`.")))
1112+
"Invalid parameters `invalidParam1,invalidParam2` found in Ivy URI query " +
1113+
"`invalidParam1=foo&invalidParam2=boo`.")))
11141114
}
11151115
}
11161116

core/src/test/scala/org/apache/spark/util/DependencyUtils.scala renamed to core/src/test/scala/org/apache/spark/util/DependencyUtilsSuite.scala

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,31 +30,31 @@ class DependencyUtilsSuite extends SparkFunSuite {
3030
assert(e1.contains("Expected authority at index 6: ivy://"))
3131

3232
val e2 = intercept[IllegalArgumentException] {
33-
DependencyUtils.resolveMavenDependencies(URI.create("ivy://org.apache.hive:hive-contrib"))
33+
DependencyUtils.resolveMavenDependencies(URI.create("ivy://org.apache.test:test-test"))
3434
}.getMessage
35-
assert(e2.contains("Invalid Ivy URI authority in uri ivy://org.apache.hive:hive-contrib:" +
36-
" Expected 'org:module:version', found org.apache.hive:hive-contrib."))
35+
assert(e2.contains("Invalid Ivy URI authority in uri ivy://org.apache.test:test-test: " +
36+
"Expected 'org:module:version', found org.apache.test:test-test."))
3737

3838
val e3 = intercept[IllegalArgumentException] {
3939
DependencyUtils.resolveMavenDependencies(
40-
URI.create("ivy://org.apache.hive:hive-contrib:2.3.7?foo="))
40+
URI.create("ivy://org.apache.test:test-test:1.0.0?foo="))
4141
}.getMessage
42-
assert(e3.contains("Invalid query string in Ivy URI" +
43-
" ivy://org.apache.hive:hive-contrib:2.3.7?foo=:"))
42+
assert(e3.contains("Invalid query string in Ivy URI " +
43+
"ivy://org.apache.test:test-test:1.0.0?foo=:"))
4444

4545
val e4 = intercept[IllegalArgumentException] {
4646
DependencyUtils.resolveMavenDependencies(
47-
URI.create("ivy://org.apache.hive:hive-contrib:2.3.7?bar=&baz=foo"))
47+
URI.create("ivy://org.apache.test:test-test:1.0.0?bar=&baz=foo"))
4848
}.getMessage
49-
assert(e4.contains("Invalid query string in Ivy URI" +
50-
" ivy://org.apache.hive:hive-contrib:2.3.7?bar=&baz=foo: bar=&baz=foo"))
49+
assert(e4.contains("Invalid query string in Ivy URI " +
50+
"ivy://org.apache.test:test-test:1.0.0?bar=&baz=foo: bar=&baz=foo"))
5151

5252
val e5 = intercept[IllegalArgumentException] {
5353
DependencyUtils.resolveMavenDependencies(
54-
URI.create("ivy://org.apache.hive:hive-contrib:2.3.7?exclude=org.pentaho"))
54+
URI.create("ivy://org.apache.test:test-test:1.0.0?exclude=org.apache"))
5555
}.getMessage
56-
assert(e5.contains("Invalid exclude string in Ivy URI" +
57-
" ivy://org.apache.hive:hive-contrib:2.3.7?exclude=org.pentaho:" +
58-
" expected 'org:module,org:module,..', found org.pentaho"))
56+
assert(e5.contains("Invalid exclude string in Ivy URI " +
57+
"ivy://org.apache.test:test-test:1.0.0?exclude=org.apache: " +
58+
"expected 'org:module,org:module,..', found org.apache"))
5959
}
6060
}

0 commit comments

Comments
 (0)