Skip to content

Commit 5dd632c

Browse files
committed
fix py
1 parent 254d2d2 commit 5dd632c

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -545,28 +545,22 @@ case class UnresolvedOrdinal(ordinal: Int)
545545
override lazy val resolved = false
546546
}
547547

548-
trait UnresolvedBinaryExpression extends BinaryExpression with Unevaluable {
549-
val operator: String
548+
abstract class UnresolvedBinaryExpression(operator: String)
549+
extends BinaryExpression with Unevaluable {
550550
override lazy val resolved: Boolean = false
551551
override def dataType: DataType = throw new UnresolvedException(this, "dataType")
552552
override def sql: String = s"${left.sql} $operator ${right.sql}"
553553
}
554554

555-
case class UnresolvedAdd(left: Expression, right: Expression) extends UnresolvedBinaryExpression {
556-
override val operator: String = "+"
555+
case class UnresolvedAdd(left: Expression, right: Expression)
556+
extends UnresolvedBinaryExpression("+") {
557557
}
558558

559559
case class UnresolvedSubtract(left: Expression, right: Expression)
560-
extends UnresolvedBinaryExpression {
561-
override val operator: String = "-"
562-
}
560+
extends UnresolvedBinaryExpression("-")
563561

564562
case class UnresolvedMultiply(left: Expression, right: Expression)
565-
extends UnresolvedBinaryExpression {
566-
override val operator: String = "*"
567-
}
563+
extends UnresolvedBinaryExpression("*")
568564

569565
case class UnresolvedDivide(left: Expression, right: Expression)
570-
extends UnresolvedBinaryExpression {
571-
override val operator: String = "/"
572-
}
566+
extends UnresolvedBinaryExpression("/")

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import java.nio.charset.StandardCharsets.UTF_8
2323
import java.util.concurrent.atomic.AtomicBoolean
2424

2525
import org.apache.spark.internal.Logging
26+
import org.apache.spark.sql.catalyst.analysis.UnresolvedBinaryExpression
2627
import org.apache.spark.sql.catalyst.expressions._
2728
import org.apache.spark.sql.internal.SQLConf
2829
import org.apache.spark.sql.types.{NumericType, StringType}
@@ -142,7 +143,10 @@ package object util extends Logging {
142143
"`" + name.replace("`", "``") + "`"
143144
}
144145

145-
def toPrettySQL(e: Expression): String = usePrettyExpression(e).sql
146+
def toPrettySQL(e: Expression): String = e match {
147+
case u: UnresolvedBinaryExpression => u.sql
148+
case _ => usePrettyExpression(e).sql
149+
}
146150

147151
def escapeSingleQuotedString(str: String): String = {
148152
val builder = StringBuilder.newBuilder

0 commit comments

Comments
 (0)