Skip to content

Commit 59106dc

Browse files
authored
simplify
1 parent 03305be commit 59106dc

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ final class DataFrameNaFunctions private[sql](df: DataFrame) {
488488
}
489489

490490
val columnEquals = df.sparkSession.sessionState.analyzer.resolver
491-
val fillColumnsInfo = df.schema.fields.filter { f =>
491+
val filledColumns = df.schema.fields.filter { f =>
492492
val typeMatches = (targetType, f.dataType) match {
493493
case (NumericType, dt) => dt.isInstanceOf[NumericType]
494494
case (StringType, dt) => dt == StringType
@@ -498,9 +498,7 @@ final class DataFrameNaFunctions private[sql](df: DataFrame) {
498498
}
499499
// Only fill if the column is part of the cols list.
500500
typeMatches && cols.exists(col => columnEquals(f.name, col))
501-
}.map { col =>
502-
(col.name, fillCol[T](col, value))
503501
}
504-
df.withColumns(fillColumnsInfo.map(_._1), fillColumnsInfo.map(_._2))
502+
df.withColumns(filledColumns.map(_.name), filledColumns.map(fillCol[T](_, value)))
505503
}
506504
}

0 commit comments

Comments
 (0)