Skip to content

Commit 580c701

Browse files
chutiummarmbrus
authored andcommitted
[SPARK-2729] [SQL] Forgot to match Timestamp type in ColumnBuilder
just a match forgot, found after SPARK-2710 , TimestampType can be used by a SchemaRDD generated from JDBC ResultSet Author: chutium <[email protected]> Closes #1636 from chutium/SPARK-2729 and squashes the following commits: 71af77a [chutium] [SPARK-2729] [SQL] added Timestamp in NullableColumnAccessorSuite 39cf9f8 [chutium] [SPARK-2729] add Timestamp Type into ColumnBuilder TestSuite, ref. #1636 ab6ff97 [chutium] [SPARK-2729] Forgot to match Timestamp type in ColumnBuilder
1 parent 4415722 commit 580c701

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnBuilder.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ private[sql] object ColumnBuilder {
154154
case STRING.typeId => new StringColumnBuilder
155155
case BINARY.typeId => new BinaryColumnBuilder
156156
case GENERIC.typeId => new GenericColumnBuilder
157+
case TIMESTAMP.typeId => new TimestampColumnBuilder
157158
}).asInstanceOf[ColumnBuilder]
158159

159160
builder.initialize(initialSize, columnName, useCompression)

sql/core/src/test/scala/org/apache/spark/sql/columnar/NullableColumnAccessorSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ object TestNullableColumnAccessor {
4141
class NullableColumnAccessorSuite extends FunSuite {
4242
import ColumnarTestUtils._
4343

44-
Seq(INT, LONG, SHORT, BOOLEAN, BYTE, STRING, DOUBLE, FLOAT, BINARY, GENERIC).foreach {
44+
Seq(INT, LONG, SHORT, BOOLEAN, BYTE, STRING, DOUBLE, FLOAT, BINARY, GENERIC, TIMESTAMP).foreach {
4545
testNullableColumnAccessor(_)
4646
}
4747

sql/core/src/test/scala/org/apache/spark/sql/columnar/NullableColumnBuilderSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ object TestNullableColumnBuilder {
3737
class NullableColumnBuilderSuite extends FunSuite {
3838
import ColumnarTestUtils._
3939

40-
Seq(INT, LONG, SHORT, BOOLEAN, BYTE, STRING, DOUBLE, FLOAT, BINARY, GENERIC).foreach {
40+
Seq(INT, LONG, SHORT, BOOLEAN, BYTE, STRING, DOUBLE, FLOAT, BINARY, GENERIC, TIMESTAMP).foreach {
4141
testNullableColumnBuilder(_)
4242
}
4343

0 commit comments

Comments
 (0)