[CARMEL-6511] Disable rename temp table (#1254)

* Update tables.scala

* Update tables.scala

* Update tables.scala

* Update TemporaryTableSuite.scala

Author: wangyum

sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala

@@ -247,10 +247,12 @@ case class AlterTableRenameCommand(
     val catalog = sparkSession.sessionState.catalog
     // If this is a temp view, just rename the view.
     // Otherwise, if this is a real table, we also need to uncache and invalidate the table.
-    if (catalog.isTemporaryView(oldName) || catalog.isTemporaryTable(oldName)) {
+    if (catalog.isTemporaryView(oldName)) {
       catalog.renameTable(oldName, newName)
     } else {
       val table = catalog.getTableMetadata(oldName)
+      DDLUtils.verifyOperationAllowableOnTempTable(catalog, table.identifier,
+        "AlterTableRenameCommand")
       DDLUtils.verifyAlterTableType(catalog, table, isView)
 
       DDLUtils.ddlLockSafe(sparkSession.sessionState, "Alter Table Rename", !isView) {

sql/core/src/test/scala/org/apache/spark/sql/execution/command/TemporaryTableSuite.scala

@@ -274,9 +274,10 @@ class TemporaryTableSuite extends QueryTest with SharedSparkSession {
   test("test rename temporary table") {
     withTempTable("t1", "t2") {
       sql("CREATE TEMPORARY TABLE t1 USING parquet AS SELECT 1")
-      sql("ALTER TABLE t1 RENAME TO t2")
-      assert(spark.sessionState.catalog.getTempTable("t1").isEmpty)
-      assert(spark.sessionState.catalog.getTempTable("t2").nonEmpty)
+      val e = intercept[AnalysisException] {
+        sql("ALTER TABLE t1 RENAME TO t2")
+      }
+      assert(e.message.contains("Operation not allowed"))
     }
   }
 
@@ -415,7 +416,7 @@ class TemporaryTableSuite extends QueryTest with SharedSparkSession {
     }
   }
 
-  test("rename temporary table name should case insensitive") {
+  ignore("rename temporary table name should case insensitive") {
     withTempTable("test_TMP", "test_TMP2") {
       sql("CREATE TEMPORARY TABLE test_TMP (id INT) USING PARQUET")
       sql("ALTER TABLE test_TMP rename to test_TMP2")