Skip to content

Commit 51aeb01

Browse files
committed
Filter out JVM memory in Scala rather than Bash (minor)
1 parent 9a778f6 commit 51aeb01

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

bin/spark-class

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ fi
108108

109109
# Set JAVA_OPTS to be able to load native libraries and to set heap size
110110
JAVA_OPTS="-XX:MaxPermSize=128m $OUR_JAVA_OPTS"
111+
JAVA_OPTS="$JAVA_OPTS -Xms$OUR_JAVA_MEM -Xmx$OUR_JAVA_MEM"
111112

112113
# Load extra JAVA_OPTS from conf/java-opts, if it exists
113114
if [ -e "$FWDIR/conf/java-opts" ] ; then
@@ -169,7 +170,6 @@ if [ -n "$SPARK_SUBMIT_BOOTSTRAP_DRIVER" ]; then
169170
shift
170171
exec "$RUNNER" org.apache.spark.deploy.SparkSubmitDriverBootstrapper "$@"
171172
else
172-
JAVA_OPTS="$JAVA_OPTS -Xms$OUR_JAVA_MEM -Xmx$OUR_JAVA_MEM"
173173
if [ -n "$SPARK_PRINT_LAUNCH_COMMAND" ]; then
174174
echo -n "Spark Command: " 1>&2
175175
echo "$RUNNER" -cp "$CLASSPATH" $JAVA_OPTS "$@" 1>&2

core/src/main/scala/org/apache/spark/deploy/SparkSubmitDriverBootstrapper.scala

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,16 @@ private[spark] object SparkSubmitDriverBootstrapper {
9999
javaOpts + confJavaOpts.map(" " + _).getOrElse("")
100100
}
101101

102+
val filteredJavaOpts = Utils.splitCommandString(newJavaOpts)
103+
.filterNot(_.startsWith("-Xms"))
104+
.filterNot(_.startsWith("-Xmx"))
105+
102106
// Build up command
103107
val command: Seq[String] =
104108
Seq(runner) ++
105109
Seq("-cp", newClasspath) ++
106110
Seq(newLibraryPath) ++
107-
Utils.splitCommandString(newJavaOpts) ++
111+
filteredJavaOpts ++
108112
Seq(s"-Xms$newDriverMemory", s"-Xmx$newDriverMemory") ++
109113
Seq("org.apache.spark.deploy.SparkSubmit") ++
110114
submitArgs

0 commit comments

Comments
 (0)