Style/formatting issues from code review

Author: DaveDeCaprio

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala

@@ -150,8 +150,7 @@ object StringUtils extends Logging {
         strings.foreach(result.append)
         result.append(truncateMsg)
         result.toString
-      }
-      else {
+      } else {
         super.toString
       }
     }

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/StringUtilsSuite.scala

@@ -46,25 +46,25 @@ class StringUtilsSuite extends SparkFunSuite {
 
   test("string concatenation") {
     def concat(seq: String*): String = {
-      seq.foldLeft(new StringConcat())((acc, s) => {acc.append(s); acc}).toString
+      seq.foldLeft(new StringConcat()) { (acc, s) => acc.append(s); acc }.toString
     }
 
     assert(new StringConcat().toString == "")
-    assert(concat("") == "")
-    assert(concat(null) == "")
-    assert(concat("a") == "a")
-    assert(concat("1", "2") == "12")
-    assert(concat("abc", "\n", "123") == "abc\n123")
+    assert(concat("") === "")
+    assert(concat(null) === "")
+    assert(concat("a") === "a")
+    assert(concat("1", "2") === "12")
+    assert(concat("abc", "\n", "123") === "abc\n123")
   }
 
   test("string concatenation with limit") {
     def concat(seq: String*): String = {
-      seq.foldLeft(new StringConcat(7))((acc, s) => {acc.append(s); acc}).toString
+      seq.foldLeft(new StringConcat(7)) { (acc, s) => acc.append(s); acc }.toString
     }
-    assert(concat("under") == "under")
-    assert(concat("under", "over", "extra") == "underov")
-    assert(concat("underover") == "underov")
-    assert(concat("under", "ov") == "underov")
+    assert(concat("under") === "under")
+    assert(concat("under", "over", "extra") === "underov")
+    assert(concat("underover") === "underov")
+    assert(concat("under", "ov") === "underov")
   }
 
   test("string concatenation return value") {
@@ -73,15 +73,8 @@ class StringUtilsSuite extends SparkFunSuite {
       sc.append(s)
       sc.atLimit
     }
-    assert(checkLimit("under") == false)
+    assert(checkLimit("under") === false)
     assert(checkLimit("1234567"))
     assert(checkLimit("1234567890"))
   }
-
-  test("string concatenation append after limit") {
-    val concat = new StringConcat(7)
-    concat.append("under")
-    concat.append("extra")
-    assert(concat.toString === "underex")
-  }
 }