correct it

Author: gatorsmile

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala

@@ -47,11 +47,6 @@ case class ScalaUDF(
   extends Expression with ImplicitCastInputTypes with NonSQLExpression {
 
   // the user-defined functions must be deterministic.
-  if (!super.deterministic) {
-    val name = udfName.getOrElse("")
-    throw new AnalysisException(s"User-defined functions must be deterministic. Name: $name.")
-  }
-
   final override def deterministic: Boolean = true
 
   override def nullable: Boolean = true

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDFSuite.scala

@@ -20,7 +20,6 @@ package org.apache.spark.sql.catalyst.expressions
 import java.util.Locale
 
 import org.apache.spark.{SparkException, SparkFunSuite}
-import org.apache.spark.sql.AnalysisException
 import org.apache.spark.sql.types.{IntegerType, StringType}
 
 class ScalaUDFSuite extends SparkFunSuite with ExpressionEvalHelper {
@@ -33,13 +32,6 @@ class ScalaUDFSuite extends SparkFunSuite with ExpressionEvalHelper {
     checkEvaluation(stringUdf, "ax")
   }
 
-  test("non-deterministic children") {
-    val e = intercept[AnalysisException] {
-      ScalaUDF((i: Int) => i + 1, IntegerType, Rand(1) :: Nil, Nil, Some("udf"))
-    }.getMessage
-    assert(e.contains("User-defined functions must be deterministic. Name: udf."))
-  }
-
   test("better error message for NPE") {
     val udf = ScalaUDF(
       (s: String) => s.toLowerCase(Locale.ROOT),