address comments

Author: mgaido91

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala

@@ -625,10 +625,10 @@ case class ArraysOverlap(left: Expression, right: Expression)
    */
   private def fastEval(arr1: ArrayData, arr2: ArrayData): Any = {
     var hasNull = false
-    val (bigger, smaller, biggerDt) = if (arr1.numElements() > arr2.numElements()) {
-      (arr1, arr2, left.dataType.asInstanceOf[ArrayType])
+    val (bigger, smaller) = if (arr1.numElements() > arr2.numElements()) {
+      (arr1, arr2)
     } else {
-      (arr2, arr1, right.dataType.asInstanceOf[ArrayType])
+      (arr2, arr1)
     }
     if (smaller.numElements() > 0) {
       val smallestSet = new mutable.HashSet[Any]
@@ -766,15 +766,15 @@ case class ArraysOverlap(left: Expression, right: Expression)
       s"""
          |for (int $j = 0; $j < $smaller.numElements(); $j ++) {
          |  $compareValues
-         |  if (${ev.value}) {
-         |    break;
-         |  }
          |}
        """.stripMargin,
       s"${ev.isNull} = true;")
     s"""
        |for (int $i = 0; $i < $bigger.numElements(); $i ++) {
-       |$isInSmaller
+       |  $isInSmaller
+       |  if (${ev.value}) {
+       |    break;
+       |  }
        |}
      """.stripMargin
   }

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala

@@ -161,6 +161,8 @@ class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
 
     // null handling
     checkEvaluation(ArraysOverlap(emptyIntArray, a2), false)
+    checkEvaluation(ArraysOverlap(
+      emptyIntArray, Literal.create(Seq(null), ArrayType(IntegerType))), false)
     checkEvaluation(ArraysOverlap(Literal.create(null, ArrayType(IntegerType)), a0), null)
     checkEvaluation(ArraysOverlap(a0, Literal.create(null, ArrayType(IntegerType))), null)
     checkEvaluation(ArraysOverlap(