applying review comments

Author: attilapiros

mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderEstimatorSuite.scala

@@ -398,9 +398,7 @@ class OneHotEncoderEstimatorSuite extends MLTest with DefaultReadWriteTest {
       firstResultCol = "output")
 
     model.setHandleInvalid("keep")
-    testTransformerByGlobalCheckFunc[(Double, Vector)](testDF, model, "output") { _ =>
-      Unit
-    }
+    testTransformerByGlobalCheckFunc[(Double, Vector)](testDF, model, "output") { _ => }
   }
 
   test("Transforming on mismatched attributes") {

mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala

@@ -382,7 +382,7 @@ class QuantileDiscretizerSuite extends MLTest with DefaultReadWriteTest {
       "result1",
       "result2",
       "result3") { rows =>
-        assert(rows == expected)
+        assert(rows === expected)
       }
 
     testTransformerByGlobalCheckFunc[(Double, Double, Double)](
@@ -391,7 +391,7 @@ class QuantileDiscretizerSuite extends MLTest with DefaultReadWriteTest {
       "result1",
       "result2",
       "result3") { rows =>
-      assert(rows == expected)
+      assert(rows === expected)
     }
   }
 
@@ -450,7 +450,7 @@ class QuantileDiscretizerSuite extends MLTest with DefaultReadWriteTest {
       "result1",
       "result2",
       "result3") { rows =>
-      assert(rows == expected)
+      assert(rows === expected)
     }
 
     testTransformerByGlobalCheckFunc[(Double, Double, Double)](
@@ -459,7 +459,7 @@ class QuantileDiscretizerSuite extends MLTest with DefaultReadWriteTest {
       "result1",
       "result2",
       "result3") { rows =>
-      assert(rows == expected)
+      assert(rows === expected)
     }
   }
 

mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala

@@ -34,16 +34,16 @@ class RFormulaSuite extends MLTest with DefaultReadWriteTest {
       expected: DataFrame,
       expectedAttributes: AttributeGroup*): Unit = {
     val resultSchema = formulaModel.transformSchema(dataframe.schema)
-    assert(resultSchema.json == expected.schema.json)
-    assert(resultSchema == expected.schema)
+    assert(resultSchema.json === expected.schema.json)
+    assert(resultSchema === expected.schema)
     val (first +: rest) = expected.schema.fieldNames.toSeq
     val expectedRows = expected.collect()
     testTransformerByGlobalCheckFunc[A](dataframe, formulaModel, first, rest: _*) { rows =>
       assert(rows.head.schema.toString() == resultSchema.toString())
       for (expectedAttributeGroup <- expectedAttributes) {
         val attributeGroup =
           AttributeGroup.fromStructField(rows.head.schema(expectedAttributeGroup.name))
-        assert(attributeGroup == expectedAttributeGroup)
+        assert(attributeGroup === expectedAttributeGroup)
       }
       assert(rows === expectedRows)
     }

mllib/src/test/scala/org/apache/spark/ml/feature/SQLTransformerSuite.scala

@@ -74,11 +74,7 @@ class SQLTransformerSuite extends MLTest with DefaultReadWriteTest {
     assert(df.storageLevel != StorageLevel.NONE)
     val sqlTrans = new SQLTransformer()
       .setStatement("SELECT id + 1 AS id1 FROM __THIS__")
-    testTransformerByGlobalCheckFunc[Long](
-      df,
-      sqlTrans,
-      "id1") { rows =>
-      assert(df.storageLevel != StorageLevel.NONE)
-    }
+    testTransformerByGlobalCheckFunc[Long](df, sqlTrans, "id1") { _ => }
+    assert(df.storageLevel != StorageLevel.NONE)
   }
 }

mllib/src/test/scala/org/apache/spark/ml/feature/VectorIndexerSuite.scala

@@ -127,9 +127,9 @@ class VectorIndexerSuite extends MLTest with DefaultReadWriteTest with Logging {
     MLTestingUtils.checkCopyAndUids(vectorIndexer, model)
 
     // should work
-    testTransformer[FeatureData](densePoints1, model, "indexed") { r: Row => Unit }
+    testTransformer[FeatureData](densePoints1, model, "indexed") { _ => }
     // should work
-    testTransformer[FeatureData](sparsePoints1, model, "indexed") { r: Row => Unit }
+    testTransformer[FeatureData](sparsePoints1, model, "indexed") { _ => }
 
     // If the data is local Dataset, it throws AssertionError directly.
     withClue("Did not found expected error message when fit, " +

mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala

@@ -227,9 +227,7 @@ class Word2VecSuite extends MLTest with DefaultReadWriteTest {
       .fit(ngramDF)
 
     // Just test that this transformation succeeds
-    testTransformerByGlobalCheckFunc[(Seq[String], Seq[String])](ngramDF, model, "result") { rows =>
-      Unit
-    }
+    testTransformerByGlobalCheckFunc[(Seq[String], Seq[String])](ngramDF, model, "result") { _ => }
   }
 
 }