save does not take overwrite.

Author: yhuai

sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala

@@ -519,20 +519,15 @@ trait DataFrame extends DataFrameSpecificApi with RDDApi[Row] {
   @Experimental
   override def save(path: String): Unit
 
-  @Experimental
-  override def save(path: String, overwrite: Boolean): Unit
-
   @Experimental
   override def save(
       dataSourceName: String,
-      overwrite: Boolean,
       option: (String, String),
       options: (String, String)*): Unit
 
   @Experimental
   override def save(
       dataSourceName: String,
-      overwrite: Boolean,
       options: java.util.Map[String, String]): Unit
 
   /**

sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala

@@ -343,28 +343,22 @@ private[sql] class DataFrameImpl protected[sql](
   }
 
   override def save(path: String): Unit = {
-    save(path, false)
-  }
-
-  override def save(path: String, overwrite: Boolean): Unit = {
     val dataSourceName = sqlContext.conf.defaultDataSourceName
-    save(dataSourceName, overwrite, ("path" -> path))
+    save(dataSourceName, ("path" -> path))
   }
 
   override def save(
       dataSourceName: String,
-      overwrite: Boolean,
       option: (String, String),
       options: (String, String)*): Unit = {
     ResolvedDataSource(sqlContext, dataSourceName, (option +: options).toMap, this)
   }
 
   override def save(
       dataSourceName: String,
-      overwrite: Boolean,
       options: java.util.Map[String, String]): Unit = {
     val opts = options.toSeq
-    save(dataSourceName, overwrite, opts.head, opts.tail:_*)
+    save(dataSourceName, opts.head, opts.tail:_*)
   }
 
   override def insertInto(tableName: String, overwrite: Boolean): Unit = {

sql/core/src/main/scala/org/apache/spark/sql/IncomputableColumn.scala

@@ -165,17 +165,13 @@ private[sql] class IncomputableColumn(protected[sql] val expr: Expression) exten
 
   override def save(path: String): Unit = err()
 
-  override def save(path: String, overwrite: Boolean): Unit = err()
-
   override def save(
       dataSourceName: String,
-      overwrite: Boolean,
       option: (String, String),
       options: (String, String)*): Unit = err()
 
   override def save(
       dataSourceName: String,
-      overwrite: Boolean,
       options: java.util.Map[String, String]): Unit = err()
 
   override def insertInto(tableName: String, overwrite: Boolean): Unit = err()

sql/core/src/main/scala/org/apache/spark/sql/api.scala

@@ -186,20 +186,15 @@ private[sql] trait DataFrameSpecificApi {
   @Experimental
   def save(path: String): Unit
 
-  @Experimental
-  def save(path: String, overwrite: Boolean): Unit
-
   @Experimental
   def save(
       dataSourceName: String,
-      overwrite: Boolean,
       option: (String, String),
       options: (String, String)*): Unit
 
   @Experimental
   def save(
       dataSourceName: String,
-      overwrite: Boolean,
       options: java.util.Map[String, String]): Unit
 
   @Experimental

sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala

@@ -60,34 +60,29 @@ class SaveLoadSuite extends DataSourceTest with BeforeAndAfterAll {
   }
 
   test("save with overwrite and load") {
-    df.save(path.toString, true)
-
+    df.save(path.toString)
     checkLoad
   }
 
   test("save with data source and options, and load") {
-    df.save("org.apache.spark.sql.json", true, ("path", path.toString))
-
+    df.save("org.apache.spark.sql.json", ("path", path.toString))
     checkLoad
   }
 
-  test("save and save again without overwrite") {
-    df.save(path.toString, true)
+  test("save and save again") {
+    df.save(path.toString)
 
-    val exception = intercept[RuntimeException] {
+    val message = intercept[RuntimeException] {
       df.save(path.toString)
-    }
+    }.getMessage
 
     assert(
-      exception.getMessage.contains("JSON table only support INSERT OVERWRITE for now."),
-      "JSON table should only support INSERT OVERWRITE for now.")
-  }
+      message.contains("already exists"),
+      "We should complain that the path already exists.")
 
-  test("save and save again with overwrite") {
-    df.save(path.toString, true)
-    df.save(path.toString, true)
+    if (path.exists()) Utils.deleteRecursively(path)
 
+    df.save(path.toString)
     checkLoad
   }
-
 }