Skip to content

Commit 3d1d3db

Browse files
committed
rename InstanceSuite & sort items
1 parent 6f51096 commit 3d1d3db

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -181,23 +181,24 @@ class KryoSerializer(conf: SparkConf)
181181

182182
// We can't load those class directly in order to avoid unnecessary jar dependencies.
183183
// We load them safely, ignore it if the class not found.
184-
Seq("org.apache.spark.mllib.linalg.Vector",
184+
Seq(
185+
"org.apache.spark.mllib.clustering.VectorWithNorm",
186+
"org.apache.spark.mllib.linalg.DenseMatrix",
185187
"org.apache.spark.mllib.linalg.DenseVector",
186-
"org.apache.spark.mllib.linalg.SparseVector",
187188
"org.apache.spark.mllib.linalg.Matrix",
188-
"org.apache.spark.mllib.linalg.DenseMatrix",
189189
"org.apache.spark.mllib.linalg.SparseMatrix",
190+
"org.apache.spark.mllib.linalg.SparseVector",
191+
"org.apache.spark.mllib.linalg.Vector",
190192
"org.apache.spark.mllib.regression.LabeledPoint",
191-
"org.apache.spark.mllib.clustering.VectorWithNorm",
192-
"org.apache.spark.ml.linalg.Vector",
193+
"org.apache.spark.ml.feature.Instance",
194+
"org.apache.spark.ml.feature.LabeledPoint",
195+
"org.apache.spark.ml.feature.OffsetInstance",
196+
"org.apache.spark.ml.linalg.DenseMatrix",
193197
"org.apache.spark.ml.linalg.DenseVector",
194-
"org.apache.spark.ml.linalg.SparseVector",
195198
"org.apache.spark.ml.linalg.Matrix",
196-
"org.apache.spark.ml.linalg.DenseMatrix",
197199
"org.apache.spark.ml.linalg.SparseMatrix",
198-
"org.apache.spark.ml.feature.Instance",
199-
"org.apache.spark.ml.feature.OffsetInstance",
200-
"org.apache.spark.ml.feature.LabeledPoint",
200+
"org.apache.spark.ml.linalg.SparseVector",
201+
"org.apache.spark.ml.linalg.Vector",
201202
"org.apache.spark.ml.tree.impl.TreePoint"
202203
).foreach { name =>
203204
try {

mllib/src/test/scala/org/apache/spark/ml/feature/InstanceSuit.scala renamed to mllib/src/test/scala/org/apache/spark/ml/feature/InstanceSuite.scala

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,30 +17,29 @@
1717

1818
package org.apache.spark.ml.feature
1919

20-
import scala.reflect.ClassTag
21-
2220
import org.apache.spark.{SparkConf, SparkFunSuite}
2321
import org.apache.spark.ml.linalg.Vectors
2422
import org.apache.spark.serializer.KryoSerializer
2523

26-
class InstanceSuit extends SparkFunSuite{
24+
class InstanceSuite extends SparkFunSuite{
2725
test("Kryo class register") {
2826
val conf = new SparkConf(false)
2927
conf.set("spark.kryo.registrationRequired", "true")
3028

3129
val ser = new KryoSerializer(conf).newInstance()
3230

33-
def check[T: ClassTag](t: T) {
34-
assert(ser.deserialize[T](ser.serialize(t)) === t)
35-
}
36-
3731
val instance1 = Instance(19.0, 2.0, Vectors.dense(1.0, 7.0))
3832
val instance2 = Instance(17.0, 1.0, Vectors.dense(0.0, 5.0).toSparse)
33+
Seq(instance1, instance2).foreach { i =>
34+
val i2 = ser.deserialize[Instance](ser.serialize(i))
35+
assert(i === i2)
36+
}
37+
3938
val oInstance1 = OffsetInstance(0.2, 1.0, 2.0, Vectors.dense(0.0, 5.0))
4039
val oInstance2 = OffsetInstance(0.2, 1.0, 2.0, Vectors.dense(0.0, 5.0).toSparse)
41-
check(instance1)
42-
check(instance2)
43-
check(oInstance1)
44-
check(oInstance2)
40+
Seq(oInstance1, oInstance2).foreach { o =>
41+
val o2 = ser.deserialize[OffsetInstance](ser.serialize(o))
42+
assert(o === o2)
43+
}
4544
}
4645
}

0 commit comments

Comments
 (0)