Made metrics hideable

Author: kayousterhout

core/src/main/scala/org/apache/spark/ui/ToolTips.scala

@@ -18,15 +18,18 @@
 package org.apache.spark.ui
 
 private[spark] object ToolTips {
-  val EXECUTOR_LAUNCH_TIME =
-    """Overhead associated with launching the task in its own thread on the executor."""
-
   val SCHEDULER_DELAY =
     """Scheduler delay includes time to ship the task from the scheduler to
        the executor, and time to send the task result from the executor to the scheduler. If
        scheduler delay is large, consider decreasing the size of tasks or decreasing the size
        of task results."""
 
+  val EXECUTOR_LAUNCH_TIME =
+    """Overhead associated with launching the task in its own thread on the executor."""
+
+  val TASK_DESERIALIZATION_TIME =
+    """Time spent deserializating the task closure on the executor."""
+
   val INPUT = "Bytes read from Hadoop or from Spark storage."
 
   val SHUFFLE_WRITE = "Bytes written to disk in order to be read by a shuffle in a future stage."

core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala

@@ -119,6 +119,20 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIPage("stage") {
                   <span class="additional-metric-title">GC Time</span>
                 </span>
               </li>
+              <li>
+                <span data-toggle="tooltip"
+                      title={ToolTips.EXECUTOR_LAUNCH_TIME} data-placement="right">
+                  <input type="checkbox" name={TaskDetailsClassNames.EXECUTOR_LAUNCH_TIME}/>
+                  <span class="additional-metric-title">Executor Launch Time</span>
+                </span>
+              </li>
+              <li>
+                <span data-toggle="tooltip"
+                      title={ToolTips.TASK_DESERIALIZATION_TIME} data-placement="right">
+                  <input type="checkbox" name={TaskDetailsClassNames.TASK_DESERIALIZATION_TIME}/>
+                  <span class="additional-metric-title">Task Deserialization Time</span>
+                </span>
+              </li>
               <li>
                 <span data-toggle="tooltip"
                       title={ToolTips.RESULT_SERIALIZATION_TIME} data-placement="right">
@@ -148,6 +162,8 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIPage("stage") {
           ("Executor ID / Host", ""), ("Launch Time", ""), ("Duration", ""),
           ("Scheduler Delay", TaskDetailsClassNames.SCHEDULER_DELAY),
           ("GC Time", TaskDetailsClassNames.GC_TIME),
+          ("Executor Launch Time", TaskDetailsClassNames.EXECUTOR_LAUNCH_TIME),
+          ("Task Deserialization Time", TaskDetailsClassNames.TASK_DESERIALIZATION_TIME),
           ("Result Serialization Time", TaskDetailsClassNames.RESULT_SERIALIZATION_TIME),
           ("Getting Result Time", TaskDetailsClassNames.GETTING_RESULT_TIME)) ++
         {if (hasAccumulators) Seq(("Accumulators", "")) else Nil} ++
@@ -182,16 +198,26 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIPage("stage") {
           val executorLaunchTimes = validTasks.map { case TaskUIData(_, metrics, _) =>
             metrics.get.executorLaunchTime.toDouble
           }
-          val executorLaunchTitle = <td><span data-toggle="tooltip"
-            title={ToolTips.EXECUTOR_LAUNCH_TIME} data-placement="right">Launch time</span></td>
+          val executorLaunchTitle =
+            <td>
+              <span data-toggle="tooltip" title={ToolTips.EXECUTOR_LAUNCH_TIME}
+                    data-placement="right">
+                Executor Launch Time
+              </span>
+            </td>
           val executorLaunchQuantiles =
             executorLaunchTitle +: getFormattedTimeQuantiles(executorLaunchTimes)
 
           val deserializationTimes = validTasks.map { case TaskUIData(_, metrics, _) =>
             metrics.get.executorDeserializeTime.toDouble
           }
           val deserializationQuantiles =
-            <td>Task deserialization time</td> +: getFormattedTimeQuantiles(deserializationTimes)
+            <td>
+              <span data-toggle="tooltip" title={ToolTips.TASK_DESERIALIZATION_TIME}
+                    data-placement="right">
+                Task Deserialization Time
+              </span>
+            </td> +: getFormattedTimeQuantiles(deserializationTimes)
 
           val serviceTimes = validTasks.map { case TaskUIData(_, metrics, _) =>
             metrics.get.executorRunTime.toDouble
@@ -333,7 +359,10 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIPage("stage") {
         else metrics.map(m => UIUtils.formatDuration(m.executorRunTime)).getOrElse("")
       val schedulerDelay = getSchedulerDelay(info, metrics.get)
       val gcTime = metrics.map(_.jvmGCTime).getOrElse(0L)
+      val executorLaunchTime = metrics.map(_.executorLaunchTime).getOrElse(0L)
+      val taskDeserializationTime = metrics.map(_.executorDeserializeTime).getOrElse(0L)
       val serializationTime = metrics.map(_.resultSerializationTime).getOrElse(0L)
+
       val gettingResultTime = info.gettingResultTime
 
       val maybeAccumulators = info.accumulables
@@ -389,6 +418,14 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIPage("stage") {
         <td sorttable_customkey={gcTime.toString} class={TaskDetailsClassNames.GC_TIME}>
           {if (gcTime > 0) UIUtils.formatDuration(gcTime) else ""}
         </td>
+        <td sorttable_customkey={executorLaunchTime.toString}
+            class={TaskDetailsClassNames.EXECUTOR_LAUNCH_TIME}>
+          {UIUtils.formatDuration(executorLaunchTime.toLong)}
+        </td>
+        <td sorttable_customkey={taskDeserializationTime.toString}
+            class={TaskDetailsClassNames.TASK_DESERIALIZATION_TIME}>
+          {UIUtils.formatDuration(taskDeserializationTime.toLong)}
+        </td>
         <td sorttable_customkey={serializationTime.toString}
             class={TaskDetailsClassNames.RESULT_SERIALIZATION_TIME}>
           {UIUtils.formatDuration(serializationTime)}