address comments

Author: huaxingao

python/pyspark/ml/classification.py

@@ -1179,12 +1179,12 @@ class GBTClassifierParams(GBTParams, HasVarianceImpurity):
                      "Supported options: " + ", ".join(supportedLossTypes),
                      typeConverter=TypeConverters.toString)
 
-    @since("3.0.0")
-    def setLossType(self, value):
+    @since("1.4.0")
+    def getLossType(self):
         """
-        Sets the value of :py:attr:`lossType`.
+        Gets the value of lossType or its default value.
         """
-        return self._set(lossType=value)
+        return self.getOrDefault(self.lossType)
 
 
 @inherit_doc
@@ -1311,6 +1311,13 @@ def setParams(self, featuresCol="features", labelCol="label", predictionCol="pre
     def _create_model(self, java_model):
         return GBTClassificationModel(java_model)
 
+    @since("1.4.0")
+    def setLossType(self, value):
+        """
+        Sets the value of :py:attr:`lossType`.
+        """
+        return self._set(lossType=value)
+
     @since("2.4.0")
     def setFeatureSubsetStrategy(self, value):
         """

python/pyspark/ml/regression.py

@@ -727,13 +727,6 @@ class GBTParams(TreeEnsembleParams, HasMaxIter, HasStepSize, HasValidationIndica
                           "This parameter is ignored when fit without validation is used.",
                           typeConverter=TypeConverters.toFloat)
 
-    @since("3.0.0")
-    def setValidationTol(self, value):
-        """
-        Sets the value of :py:attr:`validationTol`.
-        """
-        return self._set(validationTol=value)
-
     @since("3.0.0")
     def getValidationTol(self):
         """
@@ -757,11 +750,11 @@ class GBTRegressorParams(GBTParams, TreeRegressorParams):
                      typeConverter=TypeConverters.toString)
 
     @since("1.4.0")
-    def setLossType(self, value):
+    def getLossType(self):
         """
-        Sets the value of :py:attr:`lossType`.
+        Gets the value of lossType or its default value.
         """
-        return self._set(lossType=value)
+        return self.getOrDefault(self.lossType)
 
 
 @inherit_doc
@@ -1187,6 +1180,13 @@ def setParams(self, featuresCol="features", labelCol="label", predictionCol="pre
     def _create_model(self, java_model):
         return GBTRegressionModel(java_model)
 
+    @since("1.4.0")
+    def setLossType(self, value):
+        """
+        Sets the value of :py:attr:`lossType`.
+        """
+        return self._set(lossType=value)
+
     @since("2.4.0")
     def setFeatureSubsetStrategy(self, value):
         """