review comment

mgaido91 · mgaido91 · commit 2bc5cb4948f7 · 2018-01-24T16:17:42.000+01:00
diff --git a/mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala b/mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala
@@ -408,6 +408,9 @@ class BucketizerSuite extends SparkFunSuite with MLlibTestSparkContext with Defa
     // the following should fail because not all the params are set
     ParamsSuite.testExclusiveParams(new Bucketizer, df, ("inputCol", "feature1"),
       ("outputCol", "result1"))
+    ParamsSuite.testExclusiveParams(new Bucketizer, df,
+      ("inputCols", Array("feature1", "feature2")),
+      ("outputCols", Array("result1", "result2")))
   }
 }
 
diff --git a/mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala b/mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
@@ -22,7 +22,6 @@ import java.io.{ByteArrayOutputStream, ObjectOutputStream}
 import org.apache.spark.SparkFunSuite
 import org.apache.spark.ml.{Estimator, Transformer}
 import org.apache.spark.ml.linalg.{Vector, Vectors}
-import org.apache.spark.ml.param.shared.{HasInputCol, HasInputCols, HasOutputCol, HasOutputCols}
 import org.apache.spark.ml.util.MyParams
 import org.apache.spark.sql.Dataset
 

Original file line number	Diff line number	Diff line change
`@@ -408,6 +408,9 @@ class BucketizerSuite extends SparkFunSuite with MLlibTestSparkContext with Defa`
`408`	`408`	`// the following should fail because not all the params are set`
`409`	`409`	`ParamsSuite.testExclusiveParams(new Bucketizer, df, ("inputCol", "feature1"),`
`410`	`410`	`("outputCol", "result1"))`
	`411`	`+ ParamsSuite.testExclusiveParams(new Bucketizer, df,`
	`412`	`+ ("inputCols", Array("feature1", "feature2")),`
	`413`	`+ ("outputCols", Array("result1", "result2")))`
`411`	`414`	`}`
`412`	`415`	`}`
`413`	`416`