Skip to content

Commit 22405d1

Browse files
committed
SPARK-19227: remove ununsed imports and outdated comments in org.apache.spark.internal.config.ConfigEntry
1 parent de62ddf commit 22405d1

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@
1717

1818
package org.apache.spark.internal.config
1919

20-
import java.util.{Map => JMap}
21-
22-
import scala.util.matching.Regex
23-
24-
import org.apache.spark.SparkConf
25-
2620
/**
2721
* An entry contains all meta information for a configuration.
2822
*
@@ -34,7 +28,6 @@ import org.apache.spark.SparkConf
3428
* value declared as a string.
3529
*
3630
* @param key the key for the configuration
37-
* @param defaultValue the default value for the configuration
3831
* @param valueConverter how to convert a string to the value. It should throw an exception if the
3932
* string does not have the required format.
4033
* @param stringConverter how to convert a value to a string that the user can use it as a valid
@@ -76,7 +69,7 @@ private class ConfigEntryWithDefault[T] (
7669
stringConverter: T => String,
7770
doc: String,
7871
isPublic: Boolean)
79-
extends ConfigEntry(key, valueConverter, stringConverter, doc, isPublic) {
72+
extends ConfigEntry(key, valueConverter, stringConverter, doc, isPublic) {
8073

8174
override def defaultValue: Option[T] = Some(_defaultValue)
8275

@@ -95,7 +88,7 @@ private class ConfigEntryWithDefaultString[T] (
9588
stringConverter: T => String,
9689
doc: String,
9790
isPublic: Boolean)
98-
extends ConfigEntry(key, valueConverter, stringConverter, doc, isPublic) {
91+
extends ConfigEntry(key, valueConverter, stringConverter, doc, isPublic) {
9992

10093
override def defaultValue: Option[T] = Some(valueConverter(_defaultValue))
10194

@@ -118,8 +111,8 @@ private[spark] class OptionalConfigEntry[T](
118111
val rawStringConverter: T => String,
119112
doc: String,
120113
isPublic: Boolean)
121-
extends ConfigEntry[Option[T]](key, s => Some(rawValueConverter(s)),
122-
v => v.map(rawStringConverter).orNull, doc, isPublic) {
114+
extends ConfigEntry[Option[T]](key, s => Some(rawValueConverter(s)),
115+
v => v.map(rawStringConverter).orNull, doc, isPublic) {
123116

124117
override def defaultValueString: String = "<undefined>"
125118

@@ -137,7 +130,7 @@ private class FallbackConfigEntry[T] (
137130
doc: String,
138131
isPublic: Boolean,
139132
private[config] val fallback: ConfigEntry[T])
140-
extends ConfigEntry[T](key, fallback.valueConverter, fallback.stringConverter, doc, isPublic) {
133+
extends ConfigEntry[T](key, fallback.valueConverter, fallback.stringConverter, doc, isPublic) {
141134

142135
override def defaultValueString: String = s"<value of ${fallback.key}>"
143136

0 commit comments

Comments
 (0)