Skip to content

Commit 21f9a7d

Browse files
committed
Update Benchmark comments
1 parent b3d7a89 commit 21f9a7d

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,6 +412,13 @@ object FilterPushdownBenchmark extends BenchmarkBase with SQLHelper {
412412
}
413413

414414
runBenchmark(s"Predicate conversion benchmark with unbalanced Expression") {
415+
// This benchmark tests a very isolated part of the predicate pushdown process - specifically,
416+
// the individual action of converting a Spark `Expression` to an ORC `SearchArgument`.
417+
// This results in more granular numbers that can help highlight small performance
418+
// differences in this part of the code that would be hidden by slower components that
419+
// get run when a full Spark job is executed.
420+
// The benchmark below runs a more complete, end-to-end test which covers the whole pipeline
421+
// and can uncover high-level performance problems, but is bad at discriminating details.
415422
val numRows = 1
416423
val width = 2000
417424

@@ -421,7 +428,8 @@ object FilterPushdownBenchmark extends BenchmarkBase with SQLHelper {
421428
val whereColumn = (1 to numFilter)
422429
.map(i => col("c1") === lit(i))
423430
.foldLeft(lit(false))(_ || _)
424-
val benchmark = new Benchmark(s"Select 1 row with $numFilter filters",
431+
val benchmark = new Benchmark(
432+
s"Convert a filter with $numFilter columns to ORC filter",
425433
numRows, minNumIters = 5, output = output)
426434
val name = s"Native ORC Vectorized (Pushdown)"
427435
benchmark.addCase(name) { _ =>

0 commit comments

Comments
 (0)