Other feedback.

Author: Marcelo Vanzin

core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala

@@ -334,7 +334,7 @@ private[ui] class JobPage(parent: JobsTab, store: AppStatusStore) extends WebUIP
     val appStartTime = store.applicationInfo().attempts.head.startTime.getTime()
 
     content ++= makeTimeline(activeStages ++ completedStages ++ failedStages,
-        store.executorList(false), appStartTime)
+      store.executorList(false), appStartTime)
 
     content ++= UIUtils.showDagVizForJob(
       jobId, store.operationGraphForJob(jobId))

core/src/main/scala/org/apache/spark/ui/jobs/JobsTab.scala

@@ -34,14 +34,10 @@ private[ui] class JobsTab(parent: SparkUI, store: AppStatusStore)
   val killEnabled = parent.killEnabled
 
   def isFairScheduler: Boolean = {
-    val configName = "spark.scheduler.mode"
-    val config = sc match {
-      case Some(_sc) =>
-        _sc.conf.getOption(configName)
-      case _ =>
-        store.environmentInfo().sparkProperties.toMap.get(configName)
-    }
-    config.map(SchedulingMode.withName) == Some(SchedulingMode.FAIR)
+    store.environmentInfo().sparkProperties.toMap
+      .get("spark.scheduler.mode")
+      .map { mode => mode == SchedulingMode.FAIR }
+      .getOrElse(false)
   }
 
   def getSparkUser: String = parent.getSparkUser

core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala

@@ -842,7 +842,7 @@ private[ui] class TaskDataSource(
   import StagePage._
 
   // Keep an internal cache of executor log maps so that long task lists render faster.
-  private val executors = new HashMap[String, Map[String, String]]()
+  private val executorIdToLogs = new HashMap[String, Map[String, String]]()
 
   // Convert TaskData to TaskTableRowData which contains the final contents to show in the table
   // so that we can avoid creating duplicate contents during sorting the data
@@ -1006,7 +1006,7 @@ private[ui] class TaskDataSource(
   }
 
   private def executorLogs(id: String): Map[String, String] = {
-    executors.getOrElseUpdate(id,
+    executorIdToLogs.getOrElseUpdate(id,
       store.asOption(store.executorSummary(id)).map(_.executorLogs).getOrElse(Map.empty))
   }