PR fixes

Author: aayushmaanjain

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala

@@ -1716,7 +1716,7 @@ object RemoveRepetitionFromGroupExpressions extends Rule[LogicalPlan] {
 
 /**
  * Replaces GlobalLimit 0 and LocalLimit 0 nodes (subtree) with empty Local Relation, as they don't
-  * return any rows.
+ * return any rows.
  */
 object OptimizeLimitZero extends Rule[LogicalPlan] {
   // returns empty Local Relation corresponding to given plan
@@ -1734,7 +1734,7 @@ object OptimizeLimitZero extends Rule[LogicalPlan] {
     // changes up the Logical Plan.
     //
     // Replace Global Limit 0 nodes with empty Local Relation
-    case gl @ GlobalLimit(IntegerLiteral(limit), _) if limit == 0 =>
+    case gl @ GlobalLimit(IntegerLiteral(0), _) =>
       empty(gl)
 
     // Note: For all SQL queries, if a LocalLimit 0 node exists in the Logical Plan, then a
@@ -1743,7 +1743,7 @@ object OptimizeLimitZero extends Rule[LogicalPlan] {
     // then the following rule will handle that case as well.
     //
     // Replace Local Limit 0 nodes with empty Local Relation
-    case ll @ LocalLimit(IntegerLiteral(limit), _) if limit == 0 =>
+    case ll @ LocalLimit(IntegerLiteral(0), _) =>
       empty(ll)
   }
 }

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeLimitZeroSuite.scala

@@ -71,13 +71,12 @@ class OptimizeLimitZeroSuite extends PlanTest {
     (LeftOuter, Project(Seq('a, Literal(null).cast(IntegerType).as('b)), testRelation1).analyze),
     (RightOuter, LocalRelation('a.int, 'b.int)),
     (FullOuter, Project(Seq('a, Literal(null).cast(IntegerType).as('b)), testRelation1).analyze)
-  ).foreach { case (jt, answer) =>
+  ).foreach { case (jt, correctAnswer) =>
       test(s"Limit 0: for join type $jt") {
         val query = testRelation1
           .join(testRelation2.limit(0), joinType = jt, condition = Some('a.attr == 'b.attr))
 
         val optimized = Optimize.execute(query.analyze)
-        val correctAnswer = answer
 
         comparePlans(optimized, correctAnswer)
       }