Skip to content

Commit 10c437e

Browse files
committed
rename fieldSchema to fieldType
1 parent 90b8717 commit 10c437e

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ private[parquet] class ParquetFilters(
5151
private case class ParquetField(
5252
// field name in parquet file
5353
fieldName: String,
54-
// field schema type in parquet file
55-
fieldSchema: ParquetSchemaType)
54+
// field type related info in parquet file
55+
fieldType: ParquetSchemaType)
5656

5757
private case class ParquetSchemaType(
5858
originalType: OriginalType,
@@ -402,7 +402,7 @@ private[parquet] class ParquetFilters(
402402
// Parquet's type in the given file should be matched to the value's type
403403
// in the pushed filter in order to push down the filter to Parquet.
404404
def valueCanMakeFilterOn(name: String, value: Any): Boolean = {
405-
value == null || (nameToParquetField(name).fieldSchema match {
405+
value == null || (nameToParquetField(name).fieldType match {
406406
case ParquetBooleanType => value.isInstanceOf[JBoolean]
407407
case ParquetByteType | ParquetShortType | ParquetIntegerType => value.isInstanceOf[Number]
408408
case ParquetLongType => value.isInstanceOf[JLong]
@@ -449,38 +449,38 @@ private[parquet] class ParquetFilters(
449449

450450
predicate match {
451451
case sources.IsNull(name) if canMakeFilterOn(name, null) =>
452-
makeEq.lift(nameToParquetField(name).fieldSchema)
452+
makeEq.lift(nameToParquetField(name).fieldType)
453453
.map(_(nameToParquetField(name).fieldName, null))
454454
case sources.IsNotNull(name) if canMakeFilterOn(name, null) =>
455-
makeNotEq.lift(nameToParquetField(name).fieldSchema)
455+
makeNotEq.lift(nameToParquetField(name).fieldType)
456456
.map(_(nameToParquetField(name).fieldName, null))
457457

458458
case sources.EqualTo(name, value) if canMakeFilterOn(name, value) =>
459-
makeEq.lift(nameToParquetField(name).fieldSchema)
459+
makeEq.lift(nameToParquetField(name).fieldType)
460460
.map(_(nameToParquetField(name).fieldName, value))
461461
case sources.Not(sources.EqualTo(name, value)) if canMakeFilterOn(name, value) =>
462-
makeNotEq.lift(nameToParquetField(name).fieldSchema)
462+
makeNotEq.lift(nameToParquetField(name).fieldType)
463463
.map(_(nameToParquetField(name).fieldName, value))
464464

465465
case sources.EqualNullSafe(name, value) if canMakeFilterOn(name, value) =>
466-
makeEq.lift(nameToParquetField(name).fieldSchema)
466+
makeEq.lift(nameToParquetField(name).fieldType)
467467
.map(_(nameToParquetField(name).fieldName, value))
468468
case sources.Not(sources.EqualNullSafe(name, value)) if canMakeFilterOn(name, value) =>
469-
makeNotEq.lift(nameToParquetField(name).fieldSchema)
469+
makeNotEq.lift(nameToParquetField(name).fieldType)
470470
.map(_(nameToParquetField(name).fieldName, value))
471471

472472
case sources.LessThan(name, value) if canMakeFilterOn(name, value) =>
473-
makeLt.lift(nameToParquetField(name).fieldSchema)
473+
makeLt.lift(nameToParquetField(name).fieldType)
474474
.map(_(nameToParquetField(name).fieldName, value))
475475
case sources.LessThanOrEqual(name, value) if canMakeFilterOn(name, value) =>
476-
makeLtEq.lift(nameToParquetField(name).fieldSchema)
476+
makeLtEq.lift(nameToParquetField(name).fieldType)
477477
.map(_(nameToParquetField(name).fieldName, value))
478478

479479
case sources.GreaterThan(name, value) if canMakeFilterOn(name, value) =>
480-
makeGt.lift(nameToParquetField(name).fieldSchema)
480+
makeGt.lift(nameToParquetField(name).fieldType)
481481
.map(_(nameToParquetField(name).fieldName, value))
482482
case sources.GreaterThanOrEqual(name, value) if canMakeFilterOn(name, value) =>
483-
makeGtEq.lift(nameToParquetField(name).fieldSchema)
483+
makeGtEq.lift(nameToParquetField(name).fieldType)
484484
.map(_(nameToParquetField(name).fieldName, value))
485485

486486
case sources.And(lhs, rhs) =>
@@ -508,7 +508,7 @@ private[parquet] class ParquetFilters(
508508
case sources.In(name, values) if canMakeFilterOn(name, values.head)
509509
&& values.distinct.length <= pushDownInFilterThreshold =>
510510
values.distinct.flatMap { v =>
511-
makeEq.lift(nameToParquetField(name).fieldSchema)
511+
makeEq.lift(nameToParquetField(name).fieldType)
512512
.map(_(nameToParquetField(name).fieldName, v))
513513
}.reduceLeftOption(FilterApi.or)
514514

0 commit comments

Comments
 (0)