Use unsigned byte value to generate prefix

kiszk · kiszk · commit 0fea784ba014 · 2017-07-10T03:45:04.000+09:00
diff --git a/common/unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java b/common/unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java
@@ -44,7 +44,7 @@ public static long getPrefix(byte[] bytes) {
       final int minLen = Math.min(bytes.length, 8);
       long p = 0;
       for (int i = 0; i < minLen; ++i) {
-        p |= (128L + Platform.getByte(bytes, Platform.BYTE_ARRAY_OFFSET + i))
+        p |= ((long)Platform.getByte(bytes, Platform.BYTE_ARRAY_OFFSET + i) & 0xff)
             << (56 - 8 * i);
       }
       return p;

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public static long getPrefix(byte[] bytes) {`
`44`	`44`	`final int minLen = Math.min(bytes.length, 8);`
`45`	`45`	`long p = 0;`
`46`	`46`	`for (int i = 0; i < minLen; ++i) {`
`47`		`- p \|= (128L + Platform.getByte(bytes, Platform.BYTE_ARRAY_OFFSET + i))`
	`47`	`+ p \|= ((long)Platform.getByte(bytes, Platform.BYTE_ARRAY_OFFSET + i) & 0xff)`
`48`	`48`	`<< (56 - 8 * i);`
`49`	`49`	`}`
`50`	`50`	`return p;`