Skip to content

Commit 03408d3

Browse files
author
Alon Doron
committed
fix tests
1 parent a07e614 commit 03408d3

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -726,7 +726,7 @@ class DataFrameAggregateSuite extends QueryTest with SharedSQLContext {
726726

727727
test("SPARK-26021: Double and Float 0.0/-0.0 should be equal when grouping") {
728728
val colName = "i"
729-
val doubles = Seq(0.0d, 0.0d, -0.0d).toDF(colName).groupBy(colName).count().collect()
729+
val doubles = Seq(0.0d, -0.0d, 0.0d).toDF(colName).groupBy(colName).count().collect()
730730
val floats = Seq(0.0f, -0.0f, 0.0f).toDF(colName).groupBy(colName).count().collect()
731731

732732
assert(doubles.length == 1)

sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ object QueryTest {
289289
def prepareRow(row: Row): Row = {
290290
Row.fromSeq(row.toSeq.map {
291291
case null => null
292-
case d: java.math.BigDecimal => BigDecimal(d)
292+
case bd: java.math.BigDecimal => BigDecimal(bd)
293293
// Equality of WrappedArray differs for AnyVal and AnyRef in Scala 2.12.2+
294294
case seq: Seq[_] => seq.map {
295295
case b: java.lang.Byte => b.byteValue
@@ -303,6 +303,9 @@ object QueryTest {
303303
// Convert array to Seq for easy equality check.
304304
case b: Array[_] => b.toSeq
305305
case r: Row => prepareRow(r)
306+
// spark treats -0.0 as 0.0
307+
case d: Double if d == -0.0d => 0.0d
308+
case f: Float if f == -0.0f => 0.0f
306309
case o => o
307310
})
308311
}

0 commit comments

Comments
 (0)