Copy RealmId when passing it to TaskExecutorImpl #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realm id is a request-scoped component, so we need to copy it to ensure it is available when the task is executed, even if the original realm id is no longer available because the request has completed.
adutra
requested review from
RussellSpitzer,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
dimas-b
approved these changes
Jan 27, 2025
flyrain
pushed a commit
to flyrain/polaris
that referenced
this pull request
Jan 31, 2025
This reverts commit febe4e8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realm id is a request-scoped component, so we need to copy it to ensure it is available when the task is executed, even if the original realm id is no longer available because the request has completed.
This was being done previously afair, even with Quarkus... I guess it got swollen with the many rebases of #469.