Remove CallContextCatalogFactory #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
commented
Dec 26, 2024
Contributor
Author
There was a problem hiding this comment.
Protected method, in case some tests need to override it (not the case at the moment).
adutra
force-pushed
the
remove-call-context-catalog-factory
branch
16 times, most recently
from
91f3ce3 to
29efd5e
Compare
adutra
force-pushed
the
remove-call-context-catalog-factory
branch
7 times, most recently
from
cb5fffc to
8e1167a
Compare
adutra
force-pushed
the
remove-call-context-catalog-factory
branch
from
8e1167a to
e2c5b6c
Compare
adutra
changed the title
adutra
requested review from
RussellSpitzer,
collado-mike,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
Contributor
Author
|
Ready for review. |
snazy
approved these changes
Jan 14, 2025
eric-maynard
added a commit
to eric-maynard/polaris
that referenced
this pull request
Feb 3, 2025
This reverts commit b5a5633.
eric-maynard
added a commit
to eric-maynard/polaris
that referenced
this pull request
Feb 4, 2025
This reverts commit 8a46a45.
eric-maynard
added a commit
that referenced
this pull request
Feb 4, 2025
eric-maynard
added a commit
to eric-maynard/polaris
that referenced
this pull request
Feb 6, 2025
This reverts commit 8a46a45.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
CallContextCatalogFactoryclass that becomes obsolete after the removal ofCallContext.