Skip to content

Conversation

@annafil
Copy link
Contributor

@annafil annafil commented Aug 1, 2024

Description

Adds trademark icons to respective Apache project names in first use, and trademark attribution statement to the bottom of the document.

Also updates README links to use the polaris.io domain name, while I'm in here 😉

Partially Addresses #48

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

README.md change can be previewed in this PR

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • My changes generate no new warnings

@annafil annafil requested review from jbonofre and takidau August 1, 2024 04:20
flyrain
flyrain previously approved these changes Aug 1, 2024
@jbonofre jbonofre self-requested a review August 1, 2024 16:02
@annafil annafil requested a review from jbonofre August 1, 2024 16:05
# Polaris Catalog

<a href="https://www.snowflake.com/blog/polaris-catalog-open-source/" target="_blank">Polaris Catalog</a> is an open source catalog for Apache Iceberg. Polaris Catalog implements Iceberg’s open <a href="https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml" target="_blank">REST API</a> for multi-engine interoperability with Apache Doris, Apache Flink, Apache Spark, PyIceberg, StarRocks and Trino.
<a href="https://www.snowflake.com/blog/polaris-catalog-open-source/" target="_blank">Polaris Catalog</a> is an open source catalog for Apache Iceberg :tm:. Polaris Catalog implements Iceberg’s open <a href="https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml" target="_blank">REST API</a> for multi-engine interoperability with Apache Doris :tm:, Apache Flink® , Apache Spark :tm:, StarRocks and Trino.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear.

We should use registered symbol here, not trademark (Apache Flink is correct, not the others).

See https://www.apache.org/foundation/marks/faq/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-08-01 at 9 08 49 AM

I think this should be taken care of :) Are you looking at the latest commit?

@jbonofre jbonofre self-requested a review August 1, 2024 16:06
@jbonofre jbonofre dismissed their stale review August 1, 2024 16:06

Mistake, I wanted just to comment

@annafil annafil enabled auto-merge (squash) August 1, 2024 17:56
Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @annafil !

@annafil annafil merged commit 3d70e75 into main Aug 2, 2024
@annafil annafil deleted the readme-trademarks branch August 2, 2024 16:19
fabio-rizzo-01 pushed a commit to fabio-rizzo-01/polaris that referenced this pull request Jun 20, 2025
# This is the 1st commit message:

 apache#772 fixed integration tests and synched with main

Mypy did a new release 1.16.1 and it cause our CI to fail for about 20 minutes due to missing wheel (upload not completed)
```
 | Unable to find installation candidates for mypy (1.16.1)
    |
    | This is likely not a Poetry issue.
    |
    |   - 14 candidate(s) were identified for the package
    |   - 14 wheel(s) were skipped as your project's environment does not support the identified abi tags
    |
    | Solutions:
    | Make sure the lockfile is up-to-date. You can try one of the following;
    |
    |     1. Regenerate lockfile: poetry lock --no-cache --regenerate
    |     2. Update package     : poetry update --no-cache mypy
    |
    | If neither works, please first check to verify that the mypy has published wheels available from your configured source that are compatible with your environment- ie. operating system, architecture (x86_64, arm64 etc.), python interpreter.
    |

```
This PR temporarily restrict the mypy version to avoid the similar issue.

We may consider bring poetry.lock back to git tracking so we won't automatically update test dependencies all the time

# This is the commit message apache#48:

Remove `.github/CODEOWNERS` (apache#1902)

As per this [dev-ML discussion](https://lists.apache.org/thread/jjr5w3hslk755yvxy8b3z45c7094cxdn)
# This is the commit message apache#49:

Rename quarkus as runtime (apache#1695)

# This is the commit message apache#50:

parent 3185adf
author Mend Renovate <[email protected]> 1749165686 +0200
committer Rizzo Cascio, Fabio <[email protected]> 1749646499 +0100

# This is a combination of 2 commits.
# This is the 1st commit message:

Mutable objects used for immutable values apache#772: resolved conflicts

# This is the commit message apache#51:

Mutable objects used for immutable values apache#772: fixed integration tests

# This is the commit message apache#52:

parent 3185adf
author Mend Renovate <[email protected]> 1749165686 +0200
committer Rizzo Cascio, Fabio <[email protected]> 1749646499 +0100

# This is a combination of 2 commits.
# This is the 1st commit message:

Mutable objects used for immutable values apache#772: resolved conflicts

Mutable objects used for immutable values apache#772: added final to base and core fields

Mutable objects used for immutable values apache#772: fixed tests
travis-bowen pushed a commit to travis-bowen/polaris that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants