Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,10 @@ $ curl -i -X PUT -H "Authorization: Bearer $PRINCIPAL_TOKEN" -H 'Accept: applica
-d '{"name": "polaris", "id": 100, "type": "INTERNAL", "readOnly": false}'
```

This creates a catalog called `polaris`. From here, you can use Spark to create namespaces, tables, etc.
This creates a catalog called `polaris`. From here, you can use any Iceberg REST
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can leave out these style-only changes for now?

Copy link
Author

@colebow colebow Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're in a different commit, so I can remove it if necessary. I figured it was generally an improvement worth making while we're here, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to separate style-only changes to make review easier.

compatible clients (e.g. Spark or Trino) to create namespaces, tables, etc.

You must run the following as the first query in your spark-sql shell to actually use Polaris:
You must run the following as the first query in your SQL shell to actually use Polaris:

```
use polaris;
Expand Down
Loading