Skip to content

Conversation

@eric-maynard
Copy link
Contributor

Description

This PR implements the missing doc docs/configuring-polaris-for-production.md referred to in other docs.

Type of change

This is a doc-only change

How Has This Been Tested?

This is a doc-only change

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings

Copy link
Contributor

@sfc-gh-ezubatov sfc-gh-ezubatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

…oduction

Ensure new links are rendered in web
@guitcastro
Copy link

I think #47 needs to be merged to use eclipse link.

RussellSpitzer
RussellSpitzer previously approved these changes Aug 5, 2024
Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits, but looks like a great addition to the docs.

@guitcastro
Copy link

guitcastro commented Aug 5, 2024

It's possible to also change the following code to allow config-file from outside the classpath in this PR? At PolarisEclipseLinkMetaStoreSessionImpl.loadProperties:

  private Map<String, String> loadProperties(String confFile, String persistenceUnitName) {
    if (this.properties != null) {
      return this.properties;
    }

    try {
-     InputStream input = this.getClass().getClassLoader().getResourceAsStream(confFile);
+     FileInputStream input = new FileInputStream(confFile);
   }
}

RussellSpitzer
RussellSpitzer previously approved these changes Aug 5, 2024
Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, I think we can clean up my remaining comments in a future PR if needed. The docs will be going through a lot of evolution and I think it's important we get this info out ASAP

@MonkeyCanCode
Copy link
Contributor

MonkeyCanCode commented Aug 6, 2024

It's possible to also change the following code to allow config-file from outside the classpath in this PR? At PolarisEclipseLinkMetaStoreSessionImpl.loadProperties:

  private Map<String, String> loadProperties(String confFile, String persistenceUnitName) {
    if (this.properties != null) {
      return this.properties;
    }

    try {
-     InputStream input = this.getClass().getClassLoader().getResourceAsStream(confFile);
+     FileInputStream input = new FileInputStream(confFile);
   }
}

This change won't work. This change will allow you to load an external config file but it will fail later on. See details in #79. @sfc-gh-aixu purposed a fix in #88.

@collado-mike collado-mike merged commit 919e9d8 into apache:main Aug 6, 2024
travis-bowen pushed a commit to travis-bowen/polaris that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants