-
Notifications
You must be signed in to change notification settings - Fork 331
Implement missing doc "Configuring Polaris for Production" #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing doc "Configuring Polaris for Production" #43
Conversation
sfc-gh-ezubatov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
…oduction Ensure new links are rendered in web
|
I think #47 needs to be merged to use eclipse link. |
RussellSpitzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nits, but looks like a great addition to the docs.
|
It's possible to also change the following code to allow config-file from outside the classpath in this PR? At private Map<String, String> loadProperties(String confFile, String persistenceUnitName) {
if (this.properties != null) {
return this.properties;
}
try {
- InputStream input = this.getClass().getClassLoader().getResourceAsStream(confFile);
+ FileInputStream input = new FileInputStream(confFile);
}
} |
RussellSpitzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, I think we can clean up my remaining comments in a future PR if needed. The docs will be going through a lot of evolution and I think it's important we get this info out ASAP
This change won't work. This change will allow you to load an external config file but it will fail later on. See details in #79. @sfc-gh-aixu purposed a fix in #88. |
…k when doing lookupEntity (apache#43)
Description
This PR implements the missing doc
docs/configuring-polaris-for-production.mdreferred to in other docs.Type of change
This is a doc-only change
How Has This Been Tested?
This is a doc-only change
Checklist: