Fix NPE in listCatalogs #1949
Merged
Fix NPE in listCatalogs #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
reviewed
Jun 26, 2025
Contributor
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
Thanks for the fix @andrew4699 ! PolarisAdminService changes LGTM, but I have some minor comments in test code :)
| "my-catalog-2"), | ||
| List.of()); | ||
|
|
||
| metaStoreManager.fakeEntityNotFoundIds.add(catalog1.getCatalog().getId()); |
Contributor
There was a problem hiding this comment.
Would you mind making a setter/adder method for this as opposed to accessing a public field?
| * Intended to be a delegate to TransactionalMetaStoreManagerImpl with the ability to inject faults. | ||
| * Currently, you can force loadEntity() to return ENTITY_NOT_FOUND for a set of entity IDs. | ||
| */ | ||
| public class TestPolarisMetaStoreManager extends TransactionalMetaStoreManagerImpl { |
Contributor
There was a problem hiding this comment.
Why not make it an inner class in ManagementServiceTest?
Contributor
Author
|
Updated! |
dimas-b
approved these changes
Jun 26, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
eric-maynard
approved these changes
Jun 26, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
pushed a commit
that referenced
this pull request
Aug 7, 2025
`PolarisAdminService` has multiple spots where it is working around the sub-optimal `PolarisMetaStoreManager` APIs. This results in multiple fixes like #1949 and #2258 While eventually the underlying APIs should be improved, for now we can make a single central workaround and clean up some redundant code. Also we can improve the return types as callers are not interested in details of the entity layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listCatalogs is non-atomic. It first atomically lists all entities and then iterates through each one and does an individual loadEntity call. This causes an NPE when calling
CatalogEntity::new.I don't think it's ever useful for listCatalogsUnsafe to return null since the caller isn't expecting a certain length of elements, so I just filtered it there.