Fix maxCode generation for ConnectionTypeEnum #1827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poojanilangekar
requested review from
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
snazy and
vvcephei
as code owners
poojanilangekar
requested review from
HonahX,
MonkeyCanCode,
RussellSpitzer,
ajantha-bhat,
ebyhr,
flyrain,
pingtimeout,
singhpk234 and
takidau
as code owners
Previously, the `maxCode` was generated using `AuthenticationType.values()`. It worked fine because Polaris supported the same number of Connection and Authentication types. The enum conversion would break if we add new authenication or connection types independently as in apache#1805.
poojanilangekar
force-pushed
the
connection-type-fix
branch
from
f624f59 to
cb6a618
Compare
flyrain
approved these changes
Jun 8, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
maxCodewas generated usingAuthenticationType.values(). It worked fine because Polaris supported the same number of Connection and Authentication types. The enum conversion would break if we add new authentication or connection types independently as in #1805 or other forms of federation.