Skip to content

Use toLowerCase(Locale.ROOT) to avoid lowercase capital I #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Use toLowerCase(Locale.ROOT) to avoid lowercase capital I #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion polaris-core/src/main/java/io/polaris/core/storage/PolarisStorageConfigurationInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import io.polaris.core.storage.azure.AzureStorageConfigurationInfo;
import io.polaris.core.storage.gcp.GcpStorageConfigurationInfo;
import java.util.List;
import java.util.Locale;
import java.util.Optional;
import org.jetbrains.annotations.NotNull;
import org.slf4j.Logger;
Expand Down Expand Up @@ -187,7 +188,7 @@ public static Optional<PolarisStorageConfigurationInfo> forEntityPath(

/** Validate if the provided allowed locations are valid for the storage type */
protected void validatePrefixForStorageType(String loc) {
if (!loc.toLowerCase().startsWith(storageType.prefix)) {
if (!loc.toLowerCase(Locale.ROOT).startsWith(storageType.prefix)) {
Copy link
Contributor

@ebyhr ebyhr Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about introducing a modernizer, errorprone's StringCaseLocaleUsage rule or something to find this usage automatically?

throw new IllegalArgumentException(
String.format(
"Location prefix not allowed: '%s', expected prefix: '%s'", loc, storageType.prefix));
Expand Down