Skip to content

Properly track bootstrappedRealms in InMemoryPolarisMetaStoreManagerFactory #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Properly track bootstrappedRealms in InMemoryPolarisMetaStoreManagerFactory #1352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...n/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,13 @@ public synchronized Supplier<TransactionalPersistence> getOrCreateSessionSupplie
private void bootstrapRealmsAndPrintCredentials(List<String> realms) {
RootCredentialsSet rootCredentialsSet = RootCredentialsSet.fromEnvironment();
this.bootstrapRealms(realms, rootCredentialsSet);
bootstrappedRealms.addAll(realms);
}

@Override
public Map<String, PrincipalSecretsResult> bootstrapRealms(
Iterable<String> realms, RootCredentialsSet rootCredentialsSet) {
Map<String, PrincipalSecretsResult> results = super.bootstrapRealms(realms, rootCredentialsSet);
bootstrappedRealms.addAll(results.keySet());

Map<String, RootCredentials> presetCredentials = rootCredentialsSet.credentials();
for (String realmId : realms) {
Expand All @@ -113,6 +113,9 @@ public Map<String, PrincipalSecretsResult> bootstrapRealms(
}

PrincipalSecretsResult principalSecrets = results.get(realmId);
if (principalSecrets == null) {
continue; // already bootstrapped (possible benign race)
}

String msg =
String.format(
Expand Down