-
Notifications
You must be signed in to change notification settings - Fork 332
Implement GenericTableCatalog #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eric-maynard
merged 21 commits into
apache:main
from
eric-maynard:implement-PolarisGenericTableCatalog-2
Mar 26, 2025
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4f775a6
add missing apis
eric-maynard e2fcd5e
more tests, fixes
eric-maynard 467ebcb
clean up drop
eric-maynard 5f5ca42
autolint
eric-maynard c1b2b73
Merge branch 'main' of github.com:apache/polaris into implement-Polar…
eric-maynard 34c8e96
changes per review
eric-maynard dab7279
revert iceberg messages to comply with oss tests
eric-maynard 54a47a5
another revert
eric-maynard 1ffbf07
more iceberg catalog changes
eric-maynard 113c941
autolint
eric-maynard 0230ab3
wip
eric-maynard 2e8c3f5
refactor to subtype
eric-maynard 3cfd53f
autolint
eric-maynard 5805d36
Merge branch 'main' of github.com:apache/polaris into implement-Polar…
eric-maynard 5f6fe0e
rebase
eric-maynard b7ac953
add another assert
eric-maynard f4ab891
autolint
eric-maynard e6f8170
add another best effort check
eric-maynard b677067
autolint
eric-maynard 10cb090
reduce metastore trips
eric-maynard 73cf7be
autolint
eric-maynard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
polaris-core/src/main/java/org/apache/polaris/core/entity/table/TableLikeEntity.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.polaris.core.entity.table; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonIgnore; | ||
| import jakarta.annotation.Nonnull; | ||
| import org.apache.iceberg.catalog.Namespace; | ||
| import org.apache.iceberg.catalog.TableIdentifier; | ||
| import org.apache.iceberg.rest.RESTUtil; | ||
| import org.apache.polaris.core.entity.NamespaceEntity; | ||
| import org.apache.polaris.core.entity.PolarisBaseEntity; | ||
| import org.apache.polaris.core.entity.PolarisEntity; | ||
| import org.apache.polaris.core.entity.PolarisEntityType; | ||
|
|
||
| /** | ||
| * An entity type for all table-like entities including Iceberg tables, Iceberg views, and generic | ||
| * tables. This entity maps to {@link PolarisEntityType#TABLE_LIKE} | ||
| */ | ||
| public abstract class TableLikeEntity extends PolarisEntity { | ||
|
|
||
| public TableLikeEntity(@Nonnull PolarisBaseEntity sourceEntity) { | ||
| super(sourceEntity); | ||
| } | ||
|
|
||
| @JsonIgnore | ||
| public TableIdentifier getTableIdentifier() { | ||
| Namespace parent = getParentNamespace(); | ||
| return TableIdentifier.of(parent, getName()); | ||
| } | ||
|
|
||
| @JsonIgnore | ||
| public Namespace getParentNamespace() { | ||
| String encodedNamespace = | ||
| getInternalPropertiesAsMap().get(NamespaceEntity.PARENT_NAMESPACE_KEY); | ||
| if (encodedNamespace == null) { | ||
| return Namespace.empty(); | ||
| } | ||
| return RESTUtil.decodeNamespace(encodedNamespace); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick question here, where would the subtype for the ICEBERG_TABLE OR VIEW set? I see for generic table it is set during build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those types, it's set during entity construction e.g. here