Fix annotations in PolarisEntityManager
#1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following up on apache#1131: * Fix annotations in `PolarisEntityManager` * Add unit tests for running without `EntityCache`
dimas-b
requested review from
adutra,
ashvina,
dennishuo,
eric-maynard and
jackye1995
as code owners
dimas-b
requested review from
MonkeyCanCode,
RussellSpitzer,
collado-mike,
ebyhr,
flyrain,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
Comment on lines
+33
to
+35
| protected EntityCache createEntityCache(PolarisMetaStoreManager metaStoreManager) { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
Non-blocking comment: is using null for this not existing a best practice? In Spark, you would much more commonly see Option used but that's scala.
We already use null like this in many places throughout Polaris, so even if we decide to make a change this PR can go ahead as-is
Contributor
Author
There was a problem hiding this comment.
I'm open to using Optional if we have a consensus.
This specific change is just a cleanup effort to align annotations and tests with existing behaviour :)
eric-maynard
approved these changes
Mar 11, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #1131:
Fix annotations in
PolarisEntityManagerAdd unit tests for running without
EntityCache