Allow MetaStoreManagerFactory to produce null EntityCache
#1131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following up on apache#1055, this refactoring does not remove `EntityCache`, but allows it to be `null` in principle, should a particular MetaStoreManagerFactory implementation choose not to use an `EntityCache`. * Remove bean producer for `EntityCache` (beans cannot be `null`). * Harmonize all `PolarisEntityManager` producers (explicit and CDI) to go through `RealmEntityManagerFactory` (tangential to the cache being null, but related).
dimas-b
requested review from
MonkeyCanCode,
RussellSpitzer,
collado-mike,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
dennishuo
approved these changes
Mar 8, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
dimas-b
added a commit
to dimas-b/polaris
that referenced
this pull request
Mar 10, 2025
Following up on apache#1131: * Fix annotations in `PolarisEntityManager` * Add unit tests for running without `EntityCache`
dimas-b
added a commit
that referenced
this pull request
Mar 11, 2025
Following up on #1131: * Fix annotations in `PolarisEntityManager` * Add unit tests for running without `EntityCache`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #1055, this refactoring does not remove
EntityCache, but allows it to benullin principle, should a particular MetaStoreManagerFactory implementation choose not to use anEntityCache.Remove bean producer for
EntityCache(beans cannot benull).Harmonize all
PolarisEntityManagerproducers (explicit and CDI) to go throughRealmEntityManagerFactory(tangential to the cache being null, but related).