Add logging and move test to the right package #104
Conversation
aihuaxu
force-pushed
the
aixu-add-logs-reuse-factory
branch
from
6c0a9a2 to
c7bbb3d
Compare
|
|
||
| return Persistence.createEntityManagerFactory(persistenceUnitName, properties); | ||
| } catch (Exception e) { | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
@collado-mike Didn't get your original comment "catch RuntimeException separately and just rethrow".
aihuaxu
changed the title
… for different realm
aihuaxu
force-pushed
the
aixu-add-logs-reuse-factory
branch
from
cb23532 to
c6f41a9
Compare
aihuaxu
changed the title
| // Clear to test out EntityManagerFactory creation, otherwise cached EntityManagerFactory would | ||
| // get reused |
There was a problem hiding this comment.
minor suggestion: -> Clear cache to prevent reuse
|
|
||
| // Cache to hold the EntityManagerFactory for each realm. Each realm needs a separate | ||
| // EntityManagerFactory since it connects to different databases | ||
| private static ConcurrentHashMap<String, EntityManagerFactory> realmFactories = |
There was a problem hiding this comment.
-> static final as we don't want any object of this class to reassign a new realmFactories
| @Nullable String persistenceUnitName) { | ||
| String realm = realmContext.getRealmIdentifier(); | ||
| EntityManagerFactory factory = | ||
| realmFactories.getOrDefault(realmContext.getRealmIdentifier(), null); |
There was a problem hiding this comment.
minor: realmContext.getRealmIdentifier() -> realm
@flyrain Thanks for reviewing. Updated based on the comments. Each realm communicates with its dedicated database and doesn't change. For now, I don't see the cases which we need to invalidate it. |
3 participants
Description
Add the logging and also move the PolarisEclipseLinkMetaStoreTest.java since it's in incorrect package.
Fixes #45
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Please delete options that are not relevant.