Skip to content

Commit ec97c1b

Browse files
authored
Upgrade Iceberg REST Spec to match Iceberg 1.8 (#1283)
* prep for review * reset * more changes * fixes * github action change * another build change * try api revert * re-all * custom type mappings, rebuild * autolint * polish * yank custom types * update * autolint * wip * Revert build changes * example * autolint
1 parent 0eb1096 commit ec97c1b

File tree

3 files changed

+134
-87
lines changed

3 files changed

+134
-87
lines changed

api/iceberg-service/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,3 +120,5 @@ sourceSets {
120120
tasks.named("javadoc") { dependsOn("jandex") }
121121

122122
tasks.named("processResources") { dependsOn("openApiGenerate") }
123+
124+
tasks.named("openApiGenerate") { outputs.cacheIf { false } }

service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,7 @@ public Response loadTable(
365365
String namespace,
366366
String table,
367367
String accessDelegationMode,
368+
String ifNoneMatchString,
368369
String snapshots,
369370
RealmContext realmContext,
370371
SecurityContext securityContext) {
@@ -373,9 +374,7 @@ public Response loadTable(
373374
Namespace ns = decodeNamespace(namespace);
374375
TableIdentifier tableIdentifier = TableIdentifier.of(ns, RESTUtil.decodeString(table));
375376

376-
// TODO: Populate with header value from parameter once the generated interface
377-
// contains the if-none-match header
378-
IfNoneMatch ifNoneMatch = IfNoneMatch.fromHeader(null);
377+
IfNoneMatch ifNoneMatch = IfNoneMatch.fromHeader(ifNoneMatchString);
379378

380379
if (ifNoneMatch.isWildcard()) {
381380
throw new BadRequestException("If-None-Match may not take the value of '*'");

0 commit comments

Comments
 (0)