Skip to content

Commit dcd7cc6

Browse files
authored
CI: Make helm-CI run for all changes (#1611)
Whether helm-charts work (or not) doesn't only depend on what's on the `helm/` directory, but also the production code. It's hard to figure out which changes could break the helm-charts or what the helm-charts rely on. Therefore it's likely better to run Helm-CI for all changes.
1 parent e1494bc commit dcd7cc6

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

.github/workflows/helm.yml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,7 @@ jobs:
5757
- name: Set up chart-testing
5858
uses: helm/[email protected]
5959

60-
- name: Run chart-testing (list-changed)
61-
id: list-changed
62-
run: |
63-
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }} --chart-dirs helm)
64-
if [[ -n "$changed" ]]; then
65-
echo "changed=true" >> "$GITHUB_OUTPUT"
66-
fi
67-
6860
- name: Run 'helm template' validation
69-
if: steps.list-changed.outputs.changed == 'true'
7061
run: |
7162
cd helm/polaris
7263
for f in values.yaml ci/*.yaml; do
@@ -76,27 +67,22 @@ jobs:
7667
done
7768
7869
- name: Run Helm unit tests
79-
if: steps.list-changed.outputs.changed == 'true'
8070
run: |
8171
helm plugin install https://github.com/helm-unittest/helm-unittest.git || true
8272
helm unittest helm/polaris
8373
8474
- name: Run chart-testing (lint)
85-
if: steps.list-changed.outputs.changed == 'true'
8675
run: ct lint --target-branch ${{ github.event.repository.default_branch }} --debug --charts ./helm/polaris
8776

8877
- name: Set up Minikube
89-
if: steps.list-changed.outputs.changed == 'true'
9078
uses: medyagh/[email protected]
9179

9280
- name: Print Docker info
93-
if: steps.list-changed.outputs.changed == 'true'
9481
run: |
9582
docker -v
9683
minikube docker-env
9784
9885
- name: Image build
99-
if: steps.list-changed.outputs.changed == 'true'
10086
run: |
10187
eval $(minikube -p minikube docker-env)
10288
./gradlew \
@@ -108,13 +94,11 @@ jobs:
10894
minikube image ls
10995
11096
- name: Install fixtures
111-
if: steps.list-changed.outputs.changed == 'true'
11297
run: |
11398
kubectl create namespace polaris-ns
11499
kubectl apply --namespace polaris-ns -f helm/polaris/ci/fixtures
115100
116101
- name: Run chart-testing (install)
117-
if: steps.list-changed.outputs.changed == 'true'
118102
run: |
119103
ct install --target-branch ${{ github.event.repository.default_branch }} \
120104
--namespace polaris-ns \

0 commit comments

Comments
 (0)