Skip to content

Commit 449b11c

Browse files
jbonofreflyrain
andauthored
Update CONTRIBUTING.md
Co-authored-by: Yufei Gu <[email protected]>
1 parent 8d85660 commit 449b11c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,6 @@ The Apache Polaris build currently requires Java 21 or later. There are a few to
104104
The discussion on the dev mailing list should happen before having a "ready-for-review" Pull Request.
105105
* `git log` can help you find the original/relevant authors of the code you are modifying. If you need, feel free to tag the author in your Pull Request comment if you need assistance or review.
106106
* Do not re-create a pull-request for the same change. Use one Pull Request related to the same change(s). The purpose here is to keep the history and all comments in the Pull Request.
107-
* Consider open questions and concerns in all comments of your Pull Request, provide replies and resolve addressed comments, if those don't serve reference purposes. If a comment doesn't contain `nit` or `minor` mention, please provide feedback to the comment.
107+
* Consider open questions and concerns in all comments of your Pull Request, provide replies and resolve addressed comments, if those don't serve reference purposes. If a comment doesn't contain `nit`, `minor`, or `not a blocker` mention, please provide feedback to the comment before merging.
108108
* Give time for review. For instance two working days is a good base to get first reviews and comments.
109109
* If you have the feeling that the discussions in a Pull Request are not going to a consensus, feel free to bring the discussion on the dev mailing list.

0 commit comments

Comments
 (0)