Reuse shadowJar for spark client bundle jar maven publish (#1857)

* fix spark client

* fix test failure and address feedback

* fix error

* update regression test

* update classifier name

* address comment

* add change

* update doc

* update build and readme

* add back jr

* udpate dependency

* add change

* update

* update tests

* remove merge service file

* update readme

* update readme

Author: gh-yzou

build-logic/src/main/kotlin/publishing/PublishingHelperPlugin.kt

@@ -133,11 +133,6 @@ constructor(private val softwareComponentFactory: SoftwareComponentFactory) : Pl
 
                 suppressPomMetadataWarningsFor("testFixturesApiElements")
                 suppressPomMetadataWarningsFor("testFixturesRuntimeElements")
-
-                if (project.tasks.findByName("createPolarisSparkJar") != null) {
-                  // if the project contains spark client jar, also publish the jar to maven
-                  artifact(project.tasks.named("createPolarisSparkJar").get())
-                }
               }
 
               if (

plugins/spark/README.md

@@ -29,15 +29,17 @@ Right now, the plugin only provides support for Spark 3.5, Scala version 2.12 an
 and depends on iceberg-spark-runtime 1.9.0.
 
 # Build Plugin Jar
-A task createPolarisSparkJar is added to build a jar for the Polaris Spark plugin, the jar is named as:
+A shadowJar task is added to build a jar for the Polaris Spark plugin, the jar is named as:
 `polaris-spark-<sparkVersion>_<scalaVersion>-<polarisVersion>-bundle.jar`. For example:
 `polaris-spark-3.5_2.12-0.11.0-beta-incubating-SNAPSHOT-bundle.jar`.
 
-- `./gradlew :polaris-spark-3.5_2.12:createPolarisSparkJar` -- build jar for Spark 3.5 with Scala version 2.12.
-- `./gradlew :polaris-spark-3.5_2.13:createPolarisSparkJar` -- build jar for Spark 3.5 with Scala version 2.13.
+- `./gradlew :polaris-spark-3.5_2.12:shadowJar` -- build jar for Spark 3.5 with Scala version 2.12.
+- `./gradlew :polaris-spark-3.5_2.13:shadowJar` -- build jar for Spark 3.5 with Scala version 2.13.
 
 The result jar is located at plugins/spark/v3.5/build/<scala_version>/libs after the build.
 
+The shadowJar task is also executed automatically when you run `gradlew assemble` or `gradlew build`.
+
 # Start Spark with Local Polaris Service using built Jar
 Once the jar is built, we can manually test it with Spark and a local Polaris service.
 

plugins/spark/v3.5/spark/build.gradle.kts

@@ -19,7 +19,10 @@
 
 import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
 
-plugins { id("polaris-client") }
+plugins {
+  id("polaris-client")
+  id("com.gradleup.shadow")
+}
 
 // get version information
 val sparkMajorVersion = "3.5"
@@ -34,11 +37,6 @@ val scalaLibraryVersion =
     pluginlibs.versions.scala213.get()
   }
 
-// the spark client relies on the shaded libraries from iceberg-spark-runtime, and therefore
-// uses imports like org.apache.iceberg.shaded.*. Use checkstyle_no_illegalimport.xml to allow
-// the import from shaded libraries for spark client.
-// checkstyle { configFile = rootProject.file("codestyle/checkstyle_no_illegalimport.xml") }
-
 dependencies {
   // TODO: extract a polaris-rest module as a thin layer for
   //  client to depends on.
@@ -88,7 +86,7 @@ dependencies {
   }
 }
 
-tasks.register<ShadowJar>("createPolarisSparkJar") {
+tasks.named<ShadowJar>("shadowJar") {
   archiveClassifier = "bundle"
   isZip64 = true
 

site/content/in-dev/unreleased/polaris-spark-client.md

@@ -128,3 +128,14 @@ The Polaris Spark client has the following functionality limitations:
 3) Rename a Delta table is not supported.
 4) ALTER TABLE ... SET LOCATION is not supported for DELTA table.
 5) For other non-Iceberg tables like csv, it is not supported.
+
+## Iceberg Spark Client compatibility with Polaris Spark Client
+The Polaris Spark client today depends on a specific Iceberg client version, and the version dependency is described
+in the following table:
+
+| Spark Client Version | Iceberg Spark Client Version |
+|----------------------|------------------------------|
+| 1.0.0                | 1.9.0                        |
+
+The Iceberg dependency is automatically downloaded when the Polaris package is downloaded, so there is no need to
+add the Iceberg Spark client in the `packages` configuration.