Remove REFRESH_CREDENTIALS_ENABLED from server response

Author: jasonf20

polaris-core/src/main/java/org/apache/polaris/core/storage/StorageAccessProperty.java

@@ -42,12 +42,6 @@ public enum StorageAccessProperty {
       Boolean.class, "s3.path-style-access", "whether to use S3 path style access", false),
   CLIENT_REGION(
       String.class, "client.region", "region to configure client for making requests to AWS"),
-  AWS_REFRESH_CREDENTIALS_ENABLED(
-      Boolean.class,
-      AwsClientProperties.REFRESH_CREDENTIALS_ENABLED,
-      "whether to enable automatic refresh of credentials",
-      false,
-      false),
   AWS_REFRESH_CREDENTIALS_ENDPOINT(
       String.class,
       AwsClientProperties.REFRESH_CREDENTIALS_ENDPOINT,
@@ -62,12 +56,6 @@ public enum StorageAccessProperty {
       "the time the gcs access token expires, in milliseconds",
       true,
       true),
-  GCS_REFRESH_CREDENTIALS_ENABLED(
-      Boolean.class,
-      GCPProperties.GCS_OAUTH2_REFRESH_CREDENTIALS_ENABLED,
-      "whether to enable automatic refresh of credentials",
-      false,
-      false),
   GCS_REFRESH_CREDENTIALS_ENDPOINT(
       String.class,
       GCPProperties.GCS_OAUTH2_REFRESH_CREDENTIALS_ENDPOINT,
@@ -79,12 +67,6 @@ public enum StorageAccessProperty {
   // it expects for SAS
   AZURE_ACCESS_TOKEN(String.class, "", "the azure scoped access token"),
   AZURE_SAS_TOKEN(String.class, "adls.sas-token.", "an azure shared access signature token"),
-  AZURE_REFRESH_CREDENTIALS_ENABLED(
-      Boolean.class,
-      "adls.refresh-credentials-enabled",
-      "whether to enable automatic refresh of credentials",
-      false,
-      false),
   AZURE_REFRESH_CREDENTIALS_ENDPOINT(
       String.class,
       "adls.refresh-credentials-endpoint",

polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java

@@ -123,7 +123,6 @@ public AccessConfig getSubscopedCreds(
 
     refreshCredentialsEndpoint.ifPresent(
         endpoint -> {
-          accessConfig.put(StorageAccessProperty.AWS_REFRESH_CREDENTIALS_ENABLED, "true");
           accessConfig.put(StorageAccessProperty.AWS_REFRESH_CREDENTIALS_ENDPOINT, endpoint);
         });
 

polaris-core/src/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java

@@ -188,7 +188,6 @@ static AccessConfig toAccessConfig(
     refreshCredentialsEndpoint.ifPresent(
         endpoint -> {
           accessConfig.put(StorageAccessProperty.AZURE_REFRESH_CREDENTIALS_ENDPOINT, endpoint);
-          accessConfig.put(StorageAccessProperty.AZURE_REFRESH_CREDENTIALS_ENABLED, "true");
         });
     return accessConfig.build();
   }

polaris-core/src/main/java/org/apache/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java

@@ -118,7 +118,6 @@ public AccessConfig getSubscopedCreds(
     refreshCredentialsEndpoint.ifPresent(
         endpoint -> {
           accessConfig.put(StorageAccessProperty.GCS_REFRESH_CREDENTIALS_ENDPOINT, endpoint);
-          accessConfig.put(StorageAccessProperty.GCS_REFRESH_CREDENTIALS_ENABLED, "true");
         });
 
     return accessConfig.build();

polaris-core/src/test/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegrationTest.java

@@ -58,9 +58,6 @@ public void testAzureCredentialFormatting() {
         .containsEntry(
             StorageAccessProperty.AZURE_REFRESH_CREDENTIALS_ENDPOINT.getPropertyName(),
             "endpoint/credentials");
-    Assertions.assertThat(adlsSuffixResult.extraProperties())
-        .containsEntry(
-            StorageAccessProperty.AZURE_REFRESH_CREDENTIALS_ENABLED.getPropertyName(), "true");
 
     AccessConfig blobSuffixResult =
         toAccessConfig(

polaris-core/src/test/java/org/apache/polaris/service/storage/aws/AwsCredentialsStorageIntegrationTest.java

@@ -107,8 +107,6 @@ public void testGetSubscopedCreds(String scheme) {
             StorageAccessProperty.AWS_SESSION_TOKEN_EXPIRES_AT_MS.getPropertyName(),
             String.valueOf(EXPIRE_TIME.toEpochMilli()));
     assertThat(accessConfig.extraProperties())
-        .containsEntry(
-            StorageAccessProperty.AWS_REFRESH_CREDENTIALS_ENABLED.getPropertyName(), "true")
         .containsEntry(
             StorageAccessProperty.AWS_REFRESH_CREDENTIALS_ENDPOINT.getPropertyName(),
             "/namespace/table/credentials");

polaris-core/src/test/java/org/apache/polaris/service/storage/gcp/GcpCredentialsStorageIntegrationTest.java

@@ -311,8 +311,6 @@ public void testRefreshCredentialsEndpointIsReturned() throws IOException {
             List.of("gs://bucket1/path/to/data"), List.of("gs://bucket1/path/to/data"), true);
     assertThat(accessConfig.get(StorageAccessProperty.GCS_REFRESH_CREDENTIALS_ENDPOINT))
         .isEqualTo(REFRESH_ENDPOINT);
-    assertThat(accessConfig.get(StorageAccessProperty.GCS_REFRESH_CREDENTIALS_ENABLED))
-        .isEqualTo(Boolean.TRUE.toString());
   }
 
   private boolean isNotNull(JsonNode node) {

runtime/service/src/intTest/java/org/apache/polaris/service/it/RestCatalogMinIOSpecialIT.java

@@ -269,7 +269,6 @@ public LoadTableResponse doTestCreateTable(RESTCatalog restCatalog) throws IOExc
         catalogApi.loadTableWithAccessDelegation(catalogName, id, "ALL");
     assertThat(loadTableResponse.config())
         .containsKey("s3.endpoint")
-        .containsEntry(AwsClientProperties.REFRESH_CREDENTIALS_ENABLED, Boolean.TRUE.toString())
         .containsEntry(
             AwsClientProperties.REFRESH_CREDENTIALS_ENDPOINT,
             "v1/" + catalogName + "/namespaces/test-ns/tables/t1/credentials");