Skip to content

Commit 957d1e1

Browse files
committed
[MSOURCES-119] - Archiving to jar is very slow
o Upgraded maven-archiver to 3.4.0 o Upgraded plexus-archiver to 4.1.0 o Fixed IT's which relied on "Created-By" attribute in MANIFEST.MF file.
1 parent 33f1e6e commit 957d1e1

File tree

4 files changed

+3
-20
lines changed

4 files changed

+3
-20
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ bin/
77
# Intellij
88
*.ipr
99
*.iml
10+
*~
1011
.idea
1112
out/
1213
.DS_Store

pom.xml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,17 +110,12 @@ under the License.
110110
<dependency>
111111
<groupId>org.apache.maven</groupId>
112112
<artifactId>maven-archiver</artifactId>
113-
<version>3.2.0</version>
113+
<version>3.4.0</version>
114114
</dependency>
115115
<dependency>
116116
<groupId>org.codehaus.plexus</groupId>
117117
<artifactId>plexus-archiver</artifactId>
118-
<version>3.6.0</version>
119-
</dependency>
120-
<dependency>
121-
<groupId>org.codehaus.plexus</groupId>
122-
<artifactId>plexus-utils</artifactId>
123-
<version>3.1.0</version>
118+
<version>4.1.0</version>
124119
</dependency>
125120

126121
<dependency>

src/it/MSOURCES-62/verify.bsh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,6 @@ try
4444

4545
Attributes manifest = jar.getManifest().getMainAttributes();
4646

47-
if ( !manifest.getValue( new Attributes.Name( "Created-By" ) ).startsWith( "Apache Maven" ) )
48-
{
49-
System.err.println( "Created-By not equals Apache Maven" );
50-
return false;
51-
}
52-
5347
String val = manifest.getValue( new Attributes.Name( "An-Entry" ) );
5448
System.out.println("An-Entry:'"+val+"'");
5549
if ( !"Some Value".equals( val) )

src/it/manifest-content/verify.bsh

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,6 @@ try
4242

4343
JarFile jar = new JarFile( artifact );
4444

45-
Attributes manifest = jar.getManifest().getMainAttributes();
46-
47-
if ( !manifest.getValue( new Attributes.Name( "Created-By" ) ).startsWith( "Apache Maven" ) )
48-
{
49-
System.err.println( "Created-By not equals Apache Maven" );
50-
return false;
51-
}
5245
}
5346
catch( Throwable e )
5447
{

0 commit comments

Comments
 (0)