From 190836ee259f203d1e38ea11167ba0340d451d13 Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Thu, 7 Oct 2021 11:49:20 +0200 Subject: [PATCH 1/3] Updated Redisson and HZ doco Make it clear that "it only works with Sisu" is meant for integrators, not "end users" wishing to use them with Maven. --- .../src/site/markdown/index.md.vm | 11 +++++++++-- .../src/site/markdown/index.md.vm | 11 +++++++++-- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm b/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm index cdd6ebdf3..d8cacb16e 100644 --- a/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm +++ b/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm @@ -32,12 +32,19 @@ Out of the box "hazelcast" (distributed) named lock implementations are the foll ${esc.hash}${esc.hash} Open Issues/Notes -- It only works when Sisu DI is used and not the bundled `AetherModule` or - `ServiceLocator` (Maven uses Sisu dependency injection). - Usage from plugins has not been tested yet. - The `furnace-maven-plugin` does not work this implementation because it uses `ServiceLocator` instead of dependency injection. +${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators + +To use this implementation within your project, depending on how you integrate, you have following options: +- If you use Sisu DI, then all you need is to provide this module (and it's dependencies) on classpath and you are done. +- If you use Guice, you need to add this module (and it's dependencies) upfront, and bind them explicitly. +- If you use ServiceLocator, be aware it is deprecated and you should move away from it. In this case, simplest is + to roll your own "bootstrap" class that does pretty much same thing as ServiceLocator was, and extend it to + instantiate these components as well. + ${esc.hash}${esc.hash} Installation/Testing - Create the directory `${maven.home}/lib/ext/hazelcast/`. diff --git a/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm b/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm index efb2eefea..c7e6a4968 100644 --- a/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm +++ b/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm @@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named lock implementations are the follo ${esc.hash}${esc.hash} Open Issues/Notes -- It only works when Sisu DI is used and not the bundled `AetherModule` or - `ServiceLocator` (Maven uses Sisu dependency injection). - Usage from plugins has not been tested yet. - The `furnace-maven-plugin` does not work this implementation because it uses `ServiceLocator` instead of dependency injection. +${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators + +To use this implementation within your project, depending on how you integrate, you have following options: +- If you use Sisu DI, then all you need is to provide this module (and it's dependencies) on classpath and you are done. +- If you use Guice, you need to add this module (and it's dependencies) upfront, and bind them explicitly. +- If you use ServiceLocator, be aware it is deprecated and you should move away from it. In this case, simplest is + to roll your own "bootstrap" class that does pretty much same thing as ServiceLocator was, and extend it to + instantiate these components as well. + ${esc.hash}${esc.hash} Installation/Testing - Create the directory `${maven.home}/lib/ext/redisson/`. From 016433a22594828681fbf043dbce56507a3dd89e Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Thu, 7 Oct 2021 11:56:55 +0200 Subject: [PATCH 2/3] Typo --- .../src/site/markdown/index.md.vm | 2 +- .../src/site/markdown/index.md.vm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm b/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm index d8cacb16e..90e4db5f3 100644 --- a/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm +++ b/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm @@ -40,7 +40,7 @@ ${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators To use this implementation within your project, depending on how you integrate, you have following options: - If you use Sisu DI, then all you need is to provide this module (and it's dependencies) on classpath and you are done. -- If you use Guice, you need to add this module (and it's dependencies) upfront, and bind them explicitly. +- If you use Guice, you need to add this module (and its dependencies) upfront, and bind them explicitly. - If you use ServiceLocator, be aware it is deprecated and you should move away from it. In this case, simplest is to roll your own "bootstrap" class that does pretty much same thing as ServiceLocator was, and extend it to instantiate these components as well. diff --git a/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm b/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm index c7e6a4968..101d6095d 100644 --- a/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm +++ b/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm @@ -39,7 +39,7 @@ ${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators To use this implementation within your project, depending on how you integrate, you have following options: - If you use Sisu DI, then all you need is to provide this module (and it's dependencies) on classpath and you are done. -- If you use Guice, you need to add this module (and it's dependencies) upfront, and bind them explicitly. +- If you use Guice, you need to add this module (and its dependencies) upfront, and bind them explicitly. - If you use ServiceLocator, be aware it is deprecated and you should move away from it. In this case, simplest is to roll your own "bootstrap" class that does pretty much same thing as ServiceLocator was, and extend it to instantiate these components as well. From f1633e7e7138a0580523f01cfded0cf16218dd47 Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Thu, 7 Oct 2021 11:58:07 +0200 Subject: [PATCH 3/3] Typo 2 --- .../src/site/markdown/index.md.vm | 4 ++-- .../src/site/markdown/index.md.vm | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm b/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm index 90e4db5f3..40f629c26 100644 --- a/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm +++ b/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm @@ -39,9 +39,9 @@ ${esc.hash}${esc.hash} Open Issues/Notes ${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators To use this implementation within your project, depending on how you integrate, you have following options: -- If you use Sisu DI, then all you need is to provide this module (and it's dependencies) on classpath and you are done. +- If you use Sisu DI, then all you need is to provide this module (and its dependencies) on classpath and you are done. - If you use Guice, you need to add this module (and its dependencies) upfront, and bind them explicitly. -- If you use ServiceLocator, be aware it is deprecated and you should move away from it. In this case, simplest is +- If you use ServiceLocator, be aware it is deprecated, and you should move away from it. In this case, simplest is to roll your own "bootstrap" class that does pretty much same thing as ServiceLocator was, and extend it to instantiate these components as well. diff --git a/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm b/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm index 101d6095d..951d4e5a4 100644 --- a/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm +++ b/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm @@ -38,9 +38,9 @@ ${esc.hash}${esc.hash} Open Issues/Notes ${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators To use this implementation within your project, depending on how you integrate, you have following options: -- If you use Sisu DI, then all you need is to provide this module (and it's dependencies) on classpath and you are done. +- If you use Sisu DI, then all you need is to provide this module (and its dependencies) on classpath and you are done. - If you use Guice, you need to add this module (and its dependencies) upfront, and bind them explicitly. -- If you use ServiceLocator, be aware it is deprecated and you should move away from it. In this case, simplest is +- If you use ServiceLocator, be aware it is deprecated, and you should move away from it. In this case, simplest is to roll your own "bootstrap" class that does pretty much same thing as ServiceLocator was, and extend it to instantiate these components as well.