From 841648bea3e5ae4742034e81315f6ed60428b2c7 Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Wed, 6 Oct 2021 20:12:29 +0200 Subject: [PATCH 1/4] Update build plugins --- .../maven-resolver-demo-maven-plugin/pom.xml | 2 +- pom.xml | 36 ++++++++++++++----- 2 files changed, 28 insertions(+), 10 deletions(-) diff --git a/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml b/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml index dc4c9b604..7cce4bb1c 100644 --- a/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml +++ b/maven-resolver-demos/maven-resolver-demo-maven-plugin/pom.xml @@ -101,7 +101,7 @@ maven-invoker-plugin - 3.2.1 + 3.2.2 false src/it diff --git a/pom.xml b/pom.xml index 16aeed82e..7a3c2e23d 100644 --- a/pom.xml +++ b/pom.xml @@ -73,11 +73,11 @@ ${surefire.redirectTestOutputToFile} resolver-archives/resolver-LATEST None - 0.3.4 + 0.3.5 4.2.3 30.1-jre 1.0.1 - 1.7.30 + 1.7.32 2021-09-08T20:02:55Z @@ -287,6 +287,7 @@ org.apache.maven.plugins maven-javadoc-plugin + 3.3.1 false true @@ -366,9 +367,15 @@ + + org.apache.maven.plugins + maven-jxr-plugin + 3.1.1 + org.apache.maven.plugins maven-release-plugin + 3.0.0-M4 true @@ -376,6 +383,7 @@ org.apache.maven.plugins maven-surefire-plugin + 3.0.0-M5 -Xmx128m ${surefire.redirectTestOutputToFile} @@ -387,6 +395,7 @@ org.apache.maven.plugins maven-failsafe-plugin + 3.0.0-M5 false -Xmx128m @@ -433,7 +442,7 @@ biz.aQute.bnd bnd-maven-plugin - 5.1.2 + 6.0.0 bnd-process @@ -455,6 +464,7 @@ org.apache.maven.plugins maven-jar-plugin + 3.2.0 @@ -463,18 +473,25 @@ - - org.apache.maven.plugins - maven-enforcer-plugin - 3.0.0-M3 - + + org.apache.maven.plugins + maven-enforcer-plugin + 3.0.0 + + + org.codehaus.mojo + extra-enforcer-rules + 1.4 + + + org.codehaus.mojo animal-sniffer-maven-plugin - 1.19 + 1.20 org.codehaus.mojo.signature @@ -516,6 +533,7 @@ org.apache.maven.plugins maven-jxr-plugin + 3.1.1 aggregate From 423fcac132db4bc64bef1e0ca3b156064545f3b8 Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Thu, 7 Oct 2021 11:43:40 +0200 Subject: [PATCH 2/4] Tidy up --- maven-resolver-demos/maven-resolver-demo-snippets/pom.xml | 2 +- pom.xml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml b/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml index 363aa8b36..61540dffe 100644 --- a/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml +++ b/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml @@ -38,7 +38,7 @@ org.apache.maven.resolver.demo.snippets - 3.8.1 + 3.8.3 diff --git a/pom.xml b/pom.xml index 7a3c2e23d..dba93232d 100644 --- a/pom.xml +++ b/pom.xml @@ -533,7 +533,6 @@ org.apache.maven.plugins maven-jxr-plugin - 3.1.1 aggregate From 6f3b033b3d3c4055137b4fd9df8d6d2452cd94be Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Thu, 7 Oct 2021 13:34:51 +0200 Subject: [PATCH 3/4] Updated Redisson and HZ doco (#130) Make it clear that "it only works with Sisu" is meant for integrators, not "end users" wishing to use them with Maven. --- .../src/site/markdown/index.md.vm | 11 +++++++++-- .../src/site/markdown/index.md.vm | 11 +++++++++-- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm b/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm index cdd6ebdf3..40f629c26 100644 --- a/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm +++ b/maven-resolver-named-locks-hazelcast/src/site/markdown/index.md.vm @@ -32,12 +32,19 @@ Out of the box "hazelcast" (distributed) named lock implementations are the foll ${esc.hash}${esc.hash} Open Issues/Notes -- It only works when Sisu DI is used and not the bundled `AetherModule` or - `ServiceLocator` (Maven uses Sisu dependency injection). - Usage from plugins has not been tested yet. - The `furnace-maven-plugin` does not work this implementation because it uses `ServiceLocator` instead of dependency injection. +${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators + +To use this implementation within your project, depending on how you integrate, you have following options: +- If you use Sisu DI, then all you need is to provide this module (and its dependencies) on classpath and you are done. +- If you use Guice, you need to add this module (and its dependencies) upfront, and bind them explicitly. +- If you use ServiceLocator, be aware it is deprecated, and you should move away from it. In this case, simplest is + to roll your own "bootstrap" class that does pretty much same thing as ServiceLocator was, and extend it to + instantiate these components as well. + ${esc.hash}${esc.hash} Installation/Testing - Create the directory `${maven.home}/lib/ext/hazelcast/`. diff --git a/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm b/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm index efb2eefea..951d4e5a4 100644 --- a/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm +++ b/maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm @@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named lock implementations are the follo ${esc.hash}${esc.hash} Open Issues/Notes -- It only works when Sisu DI is used and not the bundled `AetherModule` or - `ServiceLocator` (Maven uses Sisu dependency injection). - Usage from plugins has not been tested yet. - The `furnace-maven-plugin` does not work this implementation because it uses `ServiceLocator` instead of dependency injection. +${esc.hash}${esc.hash} Open Issues/Notes for Maven Resolver integrators + +To use this implementation within your project, depending on how you integrate, you have following options: +- If you use Sisu DI, then all you need is to provide this module (and its dependencies) on classpath and you are done. +- If you use Guice, you need to add this module (and its dependencies) upfront, and bind them explicitly. +- If you use ServiceLocator, be aware it is deprecated, and you should move away from it. In this case, simplest is + to roll your own "bootstrap" class that does pretty much same thing as ServiceLocator was, and extend it to + instantiate these components as well. + ${esc.hash}${esc.hash} Installation/Testing - Create the directory `${maven.home}/lib/ext/redisson/`. From 291801b487b884c7e1bfe014341d155c594ec994 Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Sat, 13 Nov 2021 15:37:42 +0100 Subject: [PATCH 4/4] Undo bnd change I am really unsure why we do this and do we do this right at all. So am not toching this plugin for now. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index dba93232d..48d0ba364 100644 --- a/pom.xml +++ b/pom.xml @@ -442,7 +442,7 @@ biz.aQute.bnd bnd-maven-plugin - 6.0.0 + 5.1.2 bnd-process