test: Add S3 partition directory verification in integration test #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 13, 2025 06:47
- Updates test fixture to use localhost instead of container IPs - Adds S3 client configuration for direct MinIO access - Comments out unused container IP resolution
Changes: - Switch MinIO image to 'latest' tag for better stability - Add port 9000 mapping for MinIO (9000:9000) - Add 'mc' as dependency for REST service to fix the race condition
Enhances append_partition_data_file_test.rs to verify correct partition layout in MinIO: - Add URL parsing to extract bucket and prefix from table location - Implement S3 ListObjectsV2 check for partition directory - Add debug logging for table location and data file paths - Verify objects exist in expected partition directory (id=100/) This helps diagnose the partition layout issue by confirming whether files are being written to the correct partitioned directory structure.
Contributor
|
Thanks @hackintoshrao for this pr. I'll convert it to draft first as it's only used for showing the expected path, but there is no guarantee in iceberg spec that it should generate such a directory. |
Member
Yes, I feel the same as @liurenjie1024. The physical layout is not part of the iceberg spec, and the writer has the ultimate authority to decide how to place them. It's better not to enforce this here. Also, cc @Fokko—what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances append_partition_data_file_test.rs to verify the correct partition
layout in MinIO:
This helps diagnose the partition layout issue by confirming whether files are being written to the correct partitioned directory structure.