fix: set key_metadata to Null by default #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feniljain
force-pushed
the
fix_key_metadata
branch
2 times, most recently
from
7150d4c to
d45f451
Compare
Xuanwo
reviewed
Dec 14, 2024
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Hi, @feniljain, thanke you for working on this. Here are some minor suggestions.
feniljain
force-pushed
the
fix_key_metadata
branch
from
92cae1b to
0fe9f34
Compare
feniljain
force-pushed
the
fix_key_metadata
branch
from
0fe9f34 to
e34474f
Compare
* test: use `None` instead of `Some` for key_metadata fields
feniljain
force-pushed
the
fix_key_metadata
branch
from
e34474f to
5a7d5ab
Compare
Xuanwo
approved these changes
Dec 14, 2024
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @feniljain for working on this, let's move!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Resolved
Closes #753
About
key_metadatafield to beOption<Vec<u8>instead of justVec<u8>